linux-kernel - Re: [PATCH v6 3/7] ASoC: codecs: wcd937x: add wcd937x codec driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Mon, 17 Jun 2024 12:55:52 +0100
From: Mark Brown <broonie@...nel.org>
To: Christophe JAILLET <christophe.jaillet@...adoo.fr>
Cc: Mohammad Rafi Shaik <quic_mohs@...cinc.com>,
	Srinivas Kandagatla <srinivas.kandagatla@...aro.org>,
	Banajit Goswami <bgoswami@...cinc.com>,
	Liam Girdwood <lgirdwood@...il.com>, Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>,
	alsa-devel@...a-project.org, linux-arm-msm@...r.kernel.org,
	linux-sound@...r.kernel.org, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org, quic_rohkumar@...cinc.com,
	quic_pkumpatl@...cinc.com, Konrad Dybcio <konrad.dybcio@...aro.org>
Subject: Re: [PATCH v6 3/7] ASoC: codecs: wcd937x: add wcd937x codec driver

On Sun, Jun 16, 2024 at 04:54:58PM +0200, Christophe JAILLET wrote:
> Le 11/06/2024 à 09:45, Mohammad Rafi Shaik a écrit :

> > +static void wcd937x_soc_codec_remove(struct snd_soc_component *component)
> > +{
> > +	struct wcd937x_priv *wcd937x = snd_soc_component_get_drvdata(component);
> > +
> > +	wcd937x_mbhc_deinit(component);
> > +	free_irq(wcd937x->aux_pdm_wd_int, wcd937x);
> > +	free_irq(wcd937x->hphl_pdm_wd_int, wcd937x);
> > +	free_irq(wcd937x->hphr_pdm_wd_int, wcd937x);

> These irq have been requested wth devm_request_threaded_irq(), so either
> this free_irq should be removed, or devm_free_irq() should be used if the
> order is important.

Yes, this should be fixed.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)