linux-kernel - Re: [PATCH V4] ALSA: hda/senarytech: add senarytech codec support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <87jzin93tl.wl-tiwai@suse.de>
Date: Mon, 17 Jun 2024 14:00:38 +0200
From: Takashi Iwai <tiwai@...e.de>
To: bo liu <bo.liu@...arytech.com>
Cc: perex@...ex.cz,
	tiwai@...e.com,
	linux-sound@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH V4] ALSA: hda/senarytech: add senarytech codec support

On Mon, 17 Jun 2024 03:46:34 +0200,
bo liu wrote:
> 
> Add initial Senarytech codec support for SN6186. Note that this hda
> patch relies on the configuration default registers to be set correctly
> (normally by BIOS/firmware) in order for it to set up pin widgets
> properly.
> 
> Signed-off-by: bo liu <bo.liu@...arytech.com>

This resulted in a build error when CONFIG_WERROR=y:

sound/pci/hda/patch_senarytech.c: In function ‘senary_auto_init’:
sound/pci/hda/patch_senarytech.c:134:29: error: unused variable ‘spec’ [-Werror=unused-variable]
  134 |         struct senary_spec *spec = codec->spec;
      |                             ^~~~
cc1: all warnings being treated as errors

It's senary_auto_init().  Could you fix and resubmit?


thanks,

Takashi