linux-kernel - Re: iwlwifi: Regression after migrating to 6.6.32

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Mon, 17 Jun 2024 13:08:04 +0100
From: Will Deacon <will@...nel.org>
To: Fabio Estevam <festevam@...il.com>
Cc: Johannes Berg <johannes@...solutions.net>,
	Baochen Qiang <quic_bqiang@...cinc.com>,
	miriam.rachel.korenblit@...el.com, kvalo@...nel.org,
	Jakub Kicinski <kuba@...nel.org>,
	linux-wireless <linux-wireless@...r.kernel.org>,
	linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: iwlwifi: Regression after migrating to 6.6.32

Hi Fabio,

On Thu, Jun 13, 2024 at 05:15:03PM -0300, Fabio Estevam wrote:
> On Thu, Jun 13, 2024 at 7:37 AM Johannes Berg <johannes@...solutions.net> wrote:
> 
> > Oh. So I guess try to pick up commit 14cebf689a78 ("swiotlb: Reinstate
> > page-alignment for mappings >= PAGE_SIZE").
> 
> Good catch, thanks!
> 
> After applying 14cebf689a78 ("swiotlb: Reinstate> page-alignment for
> mappings >= PAGE_SIZE")
> on top of 6.6.33 I no longer have the flood of alignment warnings and
> iwlwifi can be used again:
> 
> # dmesg | grep iwlwifi
> [    4.295064] iwlwifi 0000:01:00.0: enabling device (0000 -> 0002)
> [    4.305459] iwlwifi 0000:01:00.0: Detected crf-id 0x3617, cnv-id
> 0x100530 wfpm id 0x80000000
> [    4.315440] iwlwifi 0000:01:00.0: PCI dev 2723/0084, rev=0x340, rfid=0x10a100
> [    4.346029] iwlwifi 0000:01:00.0: api flags index 2 larger than
> supported by driver
> [    4.353816] iwlwifi 0000:01:00.0: TLV_FW_FSEQ_VERSION: FSEQ
> Version: 89.3.35.37
> [    4.363135] iwlwifi 0000:01:00.0: loaded firmware version
> 77.ad46c98b.0 cc-a0-77.ucode op_mode iwlmvm
> [    4.444427] iwlwifi 0000:01:00.0: Detected Intel(R) Wi-Fi 6 AX200
> 160MHz, REV=0x340
> [    4.604918] iwlwifi 0000:01:00.0: Detected RF HR B3, rfid=0x10a100
> [    4.676138] iwlwifi 0000:01:00.0: base HW address: 3c:21:9c:4e:16:6x
> [    5.339929] iwlwifi 0000:01:00.0 wlp1s0: renamed from wlan0
> [    9.840136] iwlwifi 0000:01:00.0: Registered PHC clock:
> iwlwifi-PTP, with index: 1
> 
> Will, is it OK for me to ask the stable folks to backport 14cebf689a78
> ("swiotlb: Reinstate> page-alignment for mappings >= PAGE_SIZE")
> to 6.6 stable?

If you want to backport that change, then I think you should probably
take the whole series:

https://lore.kernel.org/all/20240308152829.25754-1-will@kernel.org/

(and there were some follow-ups from Michael iirc; you're best off
checking the git history for kernel/dma/swiotlb.c).

FWIW: we have this series backported to 6.6 in the android15-6.6 tree.

Will