linux-kernel - Re: [PATCH 0/2] ASoC: dt-bindings: Convert realtek CODEC bindings to DT schema

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAEnQRZDu34eq2JQTjMGhWj1THOQ9XFOxRAVN__2ATHY5eq36QQ@mail.gmail.com>
Date: Mon, 17 Jun 2024 15:14:13 +0300
From: Daniel Baluta <daniel.baluta@...il.com>
To: Krzysztof Kozlowski <krzk@...nel.org>
Cc: Animesh Agarwal <animeshagarwal28@...il.com>, Daniel Baluta <daniel.baluta@....com>, 
	Liam Girdwood <lgirdwood@...il.com>, Mark Brown <broonie@...nel.org>, Rob Herring <robh@...nel.org>, 
	Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, linux-sound@...r.kernel.org, 
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 0/2] ASoC: dt-bindings: Convert realtek CODEC bindings to
 DT schema

On Mon, Jun 17, 2024 at 3:09 PM Krzysztof Kozlowski <krzk@...nel.org> wrote:
>
> On 17/06/2024 13:18, Daniel Baluta wrote:
> > On Fri, Jun 14, 2024 at 11:32 AM Krzysztof Kozlowski <krzk@...nel.org> wrote:
> >>
> >> On 14/06/2024 05:38, Animesh Agarwal wrote:
> >>> Hey all,
> >>> This patch series converts two of the thirteen realtek audio codec
> >>> bindings which are still in txt format to DT schema. I have chosen
> >>> these bindings as they have in tree DTS files.
> >>
> >> ... and the point of DTS is?
> >>
> >> To validate the DTS against bindings and see if they match.
> >>
> >> You received such feedback already.
> >
> > Hi Krzysztof,
> >
> > I'm afraid I don't understand your comment here.
> >
> > Animesh is saying that we are now looking only on bindings that are
> > actually used in the dts files.
>
> Yes and then one should compare the DTS with the binding, because old
> bindings are often incomplete.


Got it. Means that if DTS has more properties or so we should document them
in the yaml file.

One thing is that the bindings/properties should have never been added
in the dts
without documenting them, but that's another story.

OK, thanks for clarifications we will follow this advice.