[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <ZnAtOtwmGV1vR6Pz@casper.infradead.org>
Date: Mon, 17 Jun 2024 13:34:02 +0100
From: Matthew Wilcox <willy@...radead.org>
To: "Pankaj Raghav (Samsung)" <kernel@...kajraghav.com>
Cc: Christoph Hellwig <hch@....de>, david@...morbit.com, djwong@...nel.org,
chandan.babu@...cle.com, brauner@...nel.org,
akpm@...ux-foundation.org, mcgrof@...nel.org, linux-mm@...ck.org,
hare@...e.de, linux-kernel@...r.kernel.org,
yang@...amperecomputing.com, Zi Yan <zi.yan@...t.com>,
linux-xfs@...r.kernel.org, p.raghav@...sung.com,
linux-fsdevel@...r.kernel.org, gost.dev@...sung.com,
cl@...amperecomputing.com, john.g.garry@...cle.com
Subject: Re: [PATCH v7 03/11] filemap: allocate mapping_min_order folios in
the page cache
On Mon, Jun 17, 2024 at 09:58:37AM +0000, Pankaj Raghav (Samsung) wrote:
> > > @@ -2471,6 +2478,8 @@ static int filemap_create_folio(struct file *file,
> > > * well to keep locking rules simple.
> > > */
> > > filemap_invalidate_lock_shared(mapping);
> > > + /* index in PAGE units but aligned to min_order number of pages. */
> >
> > in PAGE_SIZE units? Maybe also make this a complete sentence?
> Yes, will do.
I'd delete the comment entirely. Anyone working on this code should
already know that folio indices are in units of PAGE_SIZE and must
be aligned, so I'm not sure what value this comment adds.
Powered by blists - more mailing lists