linux-kernel - Re: [PATCH v2 1/2] scripts: fix most issues reported by pylint

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e9c5fc69-5070-466f-af26-b72565394b46@hust.edu.cn>
Date: Mon, 17 Jun 2024 10:43:43 +0800
From: Dongliang Mu <dzm91@...t.edu.cn>
To: Yanteng Si <siyanteng@...ngson.cn>, Jonathan Corbet <corbet@....net>,
 Cheng Ziqiu <chengziqiu@...t.edu.cn>, Alex Shi <alexs@...nel.org>
Cc: linux-kernel@...r.kernel.org,
 "open list:DOCUMENTATION" <linux-doc@...r.kernel.org>
Subject: Re: [PATCH v2 1/2] scripts: fix most issues reported by pylint


On 2024/6/17 10:29, Yanteng Si wrote:
> Hi,Dongliang
>
> 在 2024/6/17 09:05, Dongliang Mu 写道:
>>
>> On 2024/6/16 03:42, Jonathan Corbet wrote:
>>> Dongliang Mu <dzm91@...t.edu.cn> writes:
>>>
>>>> Pylint reports many coding style issues of scripts/checktransupdate.py
>>>>
>>>> This patch fixes most issues with the following contents:
>>>> - add or revise comments for all functions
>>>> - use format string suggested by python
>>>>
>>>> Signed-off-by: Dongliang Mu <dzm91@...t.edu.cn>
>>>> ---
>>>>   scripts/checktransupdate.py | 55 
>>>> ++++++++++++++++---------------------
>>>>   1 file changed, 24 insertions(+), 31 deletions(-)
>>> How does this differ from v1?  Please always give that information so
>>> reviewers know what's going on.
>>
>> Hi Jon,
>>
>> Patch 1/2 in v2 patch has no difference with Patch 1/2 in v1. Randy 
>> put up some change requests about
>>
>> the help documentation, and it is written in the Patch 2/2 in v2.
>>
>> I am not sure how to show this information in Patch 1/2. How about 
>> "v1->v2: no changes"?
>>
>>
> Let's make a cover letter, just like:
>
> <https://lore.kernel.org/netdev/cover.1716973237.git.siyanteng@loongson.cn/> 
>
>
>
> you can run:
>
>
> $: git format-patch xxxxx   --cover-letter
>
I see. I will follow this rule when sending a patchset in the future.

Thanks for your helpful message.

>
> BTW,
>
> It seem that you forget to cc  linux-doc@...r.kernel.org.
>
>
> Thanks,
>
> Yanteng