linux-kernel - RE: [v20 02/13] rtase: Implement the .ndo

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0c57021d0bfc444ebe640aa4c5845496@realtek.com>
Date: Mon, 17 Jun 2024 13:28:51 +0000
From: Justin Lai <justinlai0215@...ltek.com>
To: Markus Elfring <Markus.Elfring@....de>,
        "netdev@...r.kernel.org"
	<netdev@...r.kernel.org>,
        "David S. Miller" <davem@...emloft.net>,
        "Eric
 Dumazet" <edumazet@...gle.com>,
        Jakub Kicinski <kuba@...nel.org>, Paolo Abeni
	<pabeni@...hat.com>,
        Simon Horman <horms@...nel.org>
CC: LKML <linux-kernel@...r.kernel.org>, Andrew Lunn <andrew@...n.ch>,
        Hariprasad Kelam <hkelam@...vell.com>, Jiri Pirko <jiri@...nulli.us>,
        "Larry
 Chiu" <larry.chiu@...ltek.com>,
        Ping-Ke Shih <pkshih@...ltek.com>,
        "Ratheesh
 Kannoth" <rkannoth@...vell.com>
Subject: RE: [v20 02/13] rtase: Implement the .ndo_open function


> >> How do you think about to increase the application of scope-based resource
> management?
> >> https://elixir.bootlin.com/linux/v6.10-rc3/source/include/linux/clean
> >> up.h#L8
> >
> > Due to our tx and rx each having multiple queues that need to allocate
> > descriptors, if any one of the queues fails to allocate,
> > rtase_alloc_desc() will return an error. Therefore, using 'goto'
> > here rather than directly returning seems to be reasonable.
> 
> Some goto chains can be replaced by further usage of advanced cleanup
> techniques, can't they?
> 
> Regards,
> Markus

rtase_alloc_desc() is used to allocate DMA memory. 
I'd like to ask if it's better to keep our current method?