linux-kernel - Re: [PATCH] rds:Simplify the allocation of slab caches

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0fdfe2c864b404a607c852c8a33378497f5b769f.camel@oracle.com>
Date: Tue, 18 Jun 2024 14:15:27 +0000
From: Allison Henderson <allison.henderson@...cle.com>
To: "lihongfu@...inos.cn" <lihongfu@...inos.cn>,
        "davem@...emloft.net"
	<davem@...emloft.net>,
        "kuba@...nel.org" <kuba@...nel.org>,
        "edumazet@...gle.com" <edumazet@...gle.com>,
        "pabeni@...hat.com"
	<pabeni@...hat.com>
CC: "rds-devel@....oracle.com" <rds-devel@....oracle.com>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "linux-rdma@...r.kernel.org" <linux-rdma@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] rds:Simplify the allocation of slab caches

On Mon, 2024-06-17 at 15:54 +0800, Hongfu Li wrote:
> Use the new KMEM_CACHE() macro instead of direct kmem_cache_create
> to simplify the creation of SLAB caches.
> 
> Signed-off-by: Hongfu Li <lihongfu@...inos.cn>

This change looks simple enough to me.  Thanks for the clean up.
Reviewed-by: Allison Henderson <allison.henderson@...cle.com>

> ---
>  net/rds/tcp.c      | 4 +---
>  net/rds/tcp_recv.c | 4 +---
>  2 files changed, 2 insertions(+), 6 deletions(-)
> 
> diff --git a/net/rds/tcp.c b/net/rds/tcp.c
> index d8111ac83bb6..3dc6956f66f8 100644
> --- a/net/rds/tcp.c
> +++ b/net/rds/tcp.c
> @@ -719,9 +719,7 @@ static int __init rds_tcp_init(void)
>  {
>         int ret;
>  
> -       rds_tcp_conn_slab = kmem_cache_create("rds_tcp_connection",
> -                                             sizeof(struct
> rds_tcp_connection),
> -                                             0, 0, NULL);
> +       rds_tcp_conn_slab = KMEM_CACHE(rds_tcp_connection, 0);
>         if (!rds_tcp_conn_slab) {
>                 ret = -ENOMEM;
>                 goto out;
> diff --git a/net/rds/tcp_recv.c b/net/rds/tcp_recv.c
> index c00f04a1a534..7997a19d1da3 100644
> --- a/net/rds/tcp_recv.c
> +++ b/net/rds/tcp_recv.c
> @@ -337,9 +337,7 @@ void rds_tcp_data_ready(struct sock *sk)
>  
>  int rds_tcp_recv_init(void)
>  {
> -       rds_tcp_incoming_slab = kmem_cache_create("rds_tcp_incoming",
> -                                       sizeof(struct
> rds_tcp_incoming),
> -                                       0, 0, NULL);
> +       rds_tcp_incoming_slab = KMEM_CACHE(rds_tcp_incoming, 0);
>         if (!rds_tcp_incoming_slab)
>                 return -ENOMEM;
>         return 0;