linux-kernel - Re: [PATCH 3/3] KVM: SVM: Use compound literal in lieu of __maybe

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240618134937.GFZnGQcd1iF1k5Nn1Q@fat_crate.local>
Date: Tue, 18 Jun 2024 15:49:37 +0200
From: Borislav Petkov <bp@...en8.de>
To: Sean Christopherson <seanjc@...gle.com>
Cc: Paolo Bonzini <pbonzini@...hat.com>, kvm@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/3] KVM: SVM: Use compound literal in lieu of
 __maybe_unused rdmsr() param

On Tue, Jun 18, 2024 at 06:44:40AM -0700, Sean Christopherson wrote:
> Yeah, I'm 50/50 on whether it's too clever.  I'm totally fine keeping msr_hi,
> what I really want to do is rewrite the rdmsr() macros to return values :-/

... and make them inline functions while at it? And perhaps unify that mess:
rdmsr, rdmsrl, rdmsr_safe, __rdmsr... And, and, ... And, and, ...

Yeah, it certainly needs scrubbing.

Once we agree on the approach we can split the work so that it can get done
gradually, without any humongous patchsets converting the world and flag days
and what not breakage...

Thx.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette