linux-kernel - Re: [PATCH net-next] net: core: Remove the dup_errno parameter in dev_prep_valid

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240618074840.536600bb@kernel.org>
Date: Tue, 18 Jun 2024 07:48:40 -0700
From: Jakub Kicinski <kuba@...nel.org>
To: Yajun Deng <yajun.deng@...ux.dev>
Cc: davem@...emloft.net, edumazet@...gle.com, pabeni@...hat.com,
 netdev@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH net-next] net: core: Remove the dup_errno parameter in
 dev_prep_valid_name()

On Tue, 18 Jun 2024 21:17:43 +0800 Yajun Deng wrote:
> netdev_name_in_use() return -EEXIST makes more sense if it's not NULL.

netdev_name_in_use() returns bool.

> But dev_alloc_name() should keep the -ENFILE errno.

And it does.

I don't understand what problem you're trying to fix.
The code is fine as is.