linux-kernel - Re: [PATCH v3] ptdump: add intermediate directory support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <i7zss6v6tb4gc6ul75idpiqludwfca3xpwdioznffnoo5ctslk@nhe4vb5hhwx2>
Date: Tue, 18 Jun 2024 09:54:04 -0500
From: Maxwell Bland <mbland@...orola.com>
To: Jesse Taube <mr.bossman075@...il.com>
Cc: Catalin Marinas <catalin.marinas@....com>, Will Deacon <will@...nel.org>,
        Jonathan Corbet <corbet@....net>,
        Andrew Morton <akpm@...ux-foundation.org>,
        Ard Biesheuvel <ardb@...nel.org>, Mark Rutland <mark.rutland@....com>,
        Christophe Leroy <christophe.leroy@...roup.eu>,
        Alexandre Ghiti <alexghiti@...osinc.com>,
        linux-arm-kernel@...ts.infradead.org, linux-doc@...r.kernel.org,
        linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] ptdump: add intermediate directory support

On Tue, May 21, 2024 at 12:54:34PM GMT, Jesse Taube wrote:
> On 4/30/24 12:05, Maxwell Bland wrote:
> > Add an optional note_non_leaf parameter to ptdump, causing note_page to
> > be called on non-leaf descriptors. Implement this functionality on arm64
> > by printing table descriptors along with table-specific permission sets.

Hi Jesse, sorry for the delay on this, I have been putting out fires
at motorola, and have just gotten time to sit down and rework these
patches. I have submitted a new set here:

https://lore.kernel.org/all/aw675dhrbplkitj3szjut2vyidsxokogkjj3vi76wl2x4wybtg@5rhk5ca5zpmv/

And thank you for your comments. This new version should address them.

> When you reply the email client(and git send-email???) seems to send it
> twice?

Was missing set record = /dev/null in my .muttrc, apologies!

> Typicaly docs are seperated into a seperate commit and sent as a set.

Done!

> As said by Catalin anything that can be seperated into smaller patches
> should be.

Done!

> > + | 0xffff800000000000-0xffff800080000000   2G PUD F BLK     RW               x               MEM/NORMAL            |
> It's probably good to add another space between F and BLK to show that F is
> related to the type? Also maybe add docs as to what it means, but I may just
> be dumb and its obvious to others.

Yes, the "F" for "this entry is invalid" is unintuitive. I decided to
rework this section of the docs altogether and just provide an exact
list of attributes for version 4.

> > +	static const char units[] = "BKMGTPE";
> This doesnt seem to be related to your changes is it?

Yes, I was a bit confused at this time, thinking the range specifications 
for tables should be the size of the table, rather than the size of the
region governed by the table. This is corrected in version 4 and the 
byte-sized specifier is no longer necessary.

Regards,
Maxwell Bland