| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Tue, 18 Jun 2024 16:59:09 +0200
From: Paul Menzel <pmenzel@...gen.mpg.de>
To: Guenter Roeck <linux@...ck-us.net>
Cc: linux-hwmon@...r.kernel.org, linux-i2c@...r.kernel.org,
linux-kernel@...r.kernel.org, devicetree@...r.kernel.org,
Krzysztof Kozlowski <krzk+dt@...nel.org>,
Wolfram Sang <wsa+renesas@...g-engineering.com>,
René Rebe <rene@...ctcode.de>,
Thomas Weißschuh <linux@...ssschuh.net>,
Armin Wolf <W_Armin@....de>, Stephen Horvath <s.horvath@...look.com.au>
Subject: Re: [PATCH v4 5/6] i2c: smbus: Support DDR5 SPD EEPROMs
Dear Guenter,
Am 18.06.24 um 16:23 schrieb Guenter Roeck:
> On 6/18/24 06:51, Paul Menzel wrote:
>> Am 18.06.24 um 15:32 schrieb Guenter Roeck:
>>
>>> On 6/18/24 03:25, Paul Menzel wrote:
>>> [ ... ]
>>>>
>>>> $ ls -l /sys/bus/i2c/drivers/spd5118/0-0050/eeprom
>>>> -r--r--r-- 1 root root 1024 Jun 18 12:17 /sys/bus/i2c/drivers/spd5118/0-0050/eeprom
>>>> $ cp /sys/bus/i2c/drivers/spd5118/0-0050/eeprom /tmp
>>>> cp: error reading '/sys/bus/i2c/drivers/spd5118/0-0050/eeprom': No such device or address
>>>
>>> That suggests that the i801 driver got an error when trying some chip
>>> operation.
>>> Unfortunately I have no idea what that error or the failed operation
>>> might be.
>>>
>>>> $ od -t x1 /sys/bus/i2c/drivers/spd5118/0-0050/eeprom
>>>> od: /sys/bus/i2c/drivers/spd5118/0-0050/eeprom: read error: No such device or address
>>>> 0000000
>>>>
>>>>> sudo i2cdump -y -f 0 0x50
>>>>
>>>> $ sudo LD_LIBRARY_PATH=~/src/i2c-tools/lib tools/i2cdump -y -f 0 0x50
>>>> No size specified (using byte-data access)
>>>> Error: Could not open file `/dev/i2c-0' or `/dev/i2c/0': No such file or directory
>>>>
>>> This should work after you load the "i2c-dev" module.
>>
>> Silly me. Thank you.
>>
>>> If you get it to work, please provide the output. Maybe it helps
>>> tracking down the problem.
>>
>> ```
>> $ sudo LD_LIBRARY_PATH=~/src/i2c-tools/lib tools/i2cdump -y -f 0 0x50
>> No size specified (using byte-data access)
>> 0 1 2 3 4 5 6 7 8 9 a b c d e f 0123456789abcdef
>> 00: 51 18 0a 86 32 03 32 00 00 00 00 00 ff 01 00 00 Q???2?2......?..
>> 10: 00 00 00 00 00 00 00 00 00 00 00 00 70 03 00 00 ............p?..
>> 20: 50 05 00 00 00 00 00 00 00 00 00 00 00 00 00 00 P?..............
>> 30: 00 58 01 00 00 00 00 00 00 00 00 00 00 00 00 00 .X?.............
>> 40: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
>> 50: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
>> 60: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
>> 70: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
>> 80: 30 10 12 02 04 00 20 62 00 00 00 00 90 02 00 00 0????. b....??..
>> 90: 00 00 00 00 a0 01 f2 03 7a 0d 00 00 00 00 80 3e ....????z?....?>
>> a0: 80 3e 80 3e 00 7d 80 bb 30 75 27 01 a0 00 82 00 ?>?>.}??0u'??.?.
>> b0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
>> c0: 00 00 00 00 00 00 88 13 08 88 13 08 20 4e 20 10 ......?????? N ?
>> d0: 27 10 15 34 20 10 27 10 c4 09 04 4c 1d 0c 00 00 '??4 ?'????L??..
>> e0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
>> f0: 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 00 ................
>> ```
>>
>> So (00,b) = 0x00 opposed to 0x07 in your example output.
>>
>
> Yes, that assumed that reading the nvram/eeprom succeeded, which it didn't.
> The value might also be 7 directly after booting and before loading
> the spd5118 driver.
>
> Anyway, it almost looks like setting the page doesn't work, or maybe write
> operations in general.
>
> Can you try the following ?
>
> dd if=/sys/bus/i2c/drivers/spd5118/0-0050/eeprom of=/tmp/eeprom count=64
> bs=1
>
> and
>
> dd if=/sys/bus/i2c/drivers/spd5118/0-0050/eeprom of=/tmp/eeprom count=1
> bs=64
>
> That should only try to read from page 0.
$ sudo dd if=/sys/bus/i2c/drivers/spd5118/0-0050/eeprom
of=/tmp/eeprom count=64 bs=1
64+0 records in
64+0 records out
64 bytes copied, 0.046002 s, 1.4 kB/s
$ sudo dd if=/sys/bus/i2c/drivers/spd5118/0-0050/eeprom
of=/tmp/eeprom count=1 bs=64
1+0 records in
1+0 records out
64 bytes copied, 0.000215414 s, 297 kB/s
> Also, please try to set a temperature limit, either temp1_max
> or temp1_crit. Setting temp1_max to, say, 56000, or temp1_crit
> to 84000 should do.
I did
$ tail -3 /etc/sensors3.conf
chip "spd5118-*"
set temp1_max 56000
set temp1_crit 84000
but it stays with the defaults:
```
$ sensors
spd5118-i2c-0-53
Adapter: SMBus I801 adapter at efa0
temp1: +20.8°C (low = +0.0°C, high = +55.0°C)
(crit low = +0.0°C, crit = +85.0°C)
spd5118-i2c-0-51
Adapter: SMBus I801 adapter at efa0
temp1: +21.5°C (low = +0.0°C, high = +55.0°C)
(crit low = +0.0°C, crit = +85.0°C)
coretemp-isa-0000
Adapter: ISA adapter
Package id 0: +32.0°C (high = +80.0°C, crit = +100.0°C)
Core 0: +28.0°C (high = +80.0°C, crit = +100.0°C)
Core 4: +29.0°C (high = +80.0°C, crit = +100.0°C)
Core 8: +28.0°C (high = +80.0°C, crit = +100.0°C)
Core 12: +27.0°C (high = +80.0°C, crit = +100.0°C)
Core 16: +25.0°C (high = +80.0°C, crit = +100.0°C)
Core 20: +28.0°C (high = +80.0°C, crit = +100.0°C)
Core 24: +25.0°C (high = +80.0°C, crit = +100.0°C)
Core 28: +28.0°C (high = +80.0°C, crit = +100.0°C)
Core 32: +30.0°C (high = +80.0°C, crit = +100.0°C)
Core 33: +30.0°C (high = +80.0°C, crit = +100.0°C)
Core 34: +30.0°C (high = +80.0°C, crit = +100.0°C)
Core 35: +30.0°C (high = +80.0°C, crit = +100.0°C)
Core 36: +28.0°C (high = +80.0°C, crit = +100.0°C)
Core 37: +28.0°C (high = +80.0°C, crit = +100.0°C)
Core 38: +28.0°C (high = +80.0°C, crit = +100.0°C)
Core 39: +28.0°C (high = +80.0°C, crit = +100.0°C)
Core 40: +30.0°C (high = +80.0°C, crit = +100.0°C)
Core 41: +30.0°C (high = +80.0°C, crit = +100.0°C)
Core 42: +30.0°C (high = +80.0°C, crit = +100.0°C)
Core 43: +30.0°C (high = +80.0°C, crit = +100.0°C)
Core 44: +30.0°C (high = +80.0°C, crit = +100.0°C)
Core 45: +30.0°C (high = +80.0°C, crit = +100.0°C)
Core 46: +30.0°C (high = +80.0°C, crit = +100.0°C)
Core 47: +30.0°C (high = +80.0°C, crit = +100.0°C)
spd5118-i2c-0-52
Adapter: SMBus I801 adapter at efa0
temp1: +21.5°C (low = +0.0°C, high = +55.0°C)
(crit low = +0.0°C, crit = +85.0°C)
spd5118-i2c-0-50
Adapter: SMBus I801 adapter at efa0
temp1: +21.5°C (low = +0.0°C, high = +55.0°C)
(crit low = +0.0°C, crit = +85.0°C)
```
Sorry, if I did something wrong.
Kind regards,
Paul
Powered by blists - more mailing lists