linux-kernel - Re: [PATCH v1 net-next] net: dsa: Allow only up to two HSR HW offloaded ports for KSZ9477

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240618170220.7c9217bd@wsk>
Date: Tue, 18 Jun 2024 17:02:20 +0200
From: Lukasz Majewski <lukma@...x.de>
To: Andrew Lunn <andrew@...n.ch>
Cc: Woojung.Huh@...rochip.com, dan.carpenter@...aro.org, olteanv@...il.com,
 kuba@...nel.org, netdev@...r.kernel.org, pabeni@...hat.com,
 edumazet@...gle.com, davem@...emloft.net, o.rempel@...gutronix.de,
 Tristram.Ha@...rochip.com, bigeasy@...utronix.de, horms@...nel.org,
 ricardo@...liere.net, casper.casan@...il.com, linux-kernel@...r.kernel.org,
 UNGLinuxDriver@...rochip.com
Subject: Re: [PATCH v1 net-next] net: dsa: Allow only up to two HSR HW
 offloaded ports for KSZ9477

Hi Andrew,

> > For me the:
> > 
> > NL_SET_ERR_MSG_MOD(extack, "Cannot offload more than two ports (in
> > use=0x%x)", dev->hsr_ports);
> > 
> > is fine - as it informs that no more HSR offloading is possible (and
> > allows to SW based RedBox/HSR-SAN operation).  
> 
> Does user space actually get to see it? I would expect the HSR code
> sees the EOPNOTSUPP, does not consider it an fatal error, and return 0
> to user space.
> 
> If userspace does see it, maybe we should make it clearer it is not an
> actually error. 
> 
> "Cannot offload more than two ports, using software bridging"
> 
> so something similar.
> 

Exactly - this is useful information - not error indication.

(The same case is when we do want to set the MAC address already
"taken" by ksz9477 HSR configuration.)

>    Andrew




Best regards,

Lukasz Majewski

--

DENX Software Engineering GmbH,      Managing Director: Erika Unter
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-59 Fax: (+49)-8142-66989-80 Email: lukma@...x.de

Content of type "application/pgp-signature" skipped