linux-kernel - Re: Crash when CONFIG_FORCE_NR_CPUS is set and nr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAHk-=whzYU-tOzxKg4f_i9G+D9No_r=uZ6g11w5UjkgfRZDf5g@mail.gmail.com>
Date: Tue, 18 Jun 2024 08:43:42 -0700
From: Linus Torvalds <torvalds@...ux-foundation.org>
To: Steven Rostedt <rostedt@...dmis.org>
Cc: LKML <linux-kernel@...r.kernel.org>, Masami Hiramatsu <mhiramat@...nel.org>, 
	Mark Rutland <mark.rutland@....com>, Mathieu Desnoyers <mathieu.desnoyers@...icios.com>, 
	"Paul E. McKenney" <paulmck@...nel.org>, Thomas Gleixner <tglx@...utronix.de>, 
	Peter Zijlstra <peterz@...radead.org>
Subject: Re: Crash when CONFIG_FORCE_NR_CPUS is set and nr_cpus does not match

On Tue, 18 Jun 2024 at 07:50, Steven Rostedt <rostedt@...dmis.org> wrote:
>
>
> I was confused to how rtpcp could be passing in a NULL pointer as it is
> a per cpu variable set up at boot. But I also noticed I was hitting
> this warning at boot up which I've been ignoring but now find it is
> related:
>
> [    0.128523] ------------[ cut here ]------------
> [    0.129275] WARNING: CPU: 0 PID: 0 at include/linux/cpumask.h:48 setup_nr_cpu_ids+0x11/0x30

Yeah, that warning very much means "you aren't running a valid config".

That said, I think FORCE_NR_CPUS was a mistake. It improves bitmask op
code generation a tiny bit (quite a lot actually on a micro level, but
not necessarily hugely noticeable in the big picture) by making
nr_cpu_ids a compile-time constant, but it's such a special-case
embedded-only (or "tuned for my particular machine") option that it's
just not worth it.

It's behind "EXPERT", and while that *should* mean that it doesn't get
enabled by default, I think the fact that many distros enable EXPERT
in their default distro config means that the whole thing has lost all
meaning.

If you start out with the distro config, you're magically an expert.
And when everybody is an expert, no one is.

                Linus