linux-kernel - Re: [PATCH v1] drivers/perf: apple

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <tencent_B732B857317E21CB8D887CBF8228DAA78E08@qq.com>
Date: Tue, 18 Jun 2024 23:56:48 +0800
From: Yangyu Chen <cyy@...self.name>
To: Marc Zyngier <maz@...nel.org>
Cc: linux-arm-kernel@...ts.infradead.org,
 Will Deacon <will@...nel.org>,
 Mark Rutland <mark.rutland@....com>,
 Janne Grunau <j@...nau.net>,
 Hector Martin <marcan@...can.st>,
 Asahi Lina <lina@...hilina.net>,
 asahi@...ts.linux.dev,
 Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v1] drivers/perf: apple_m1: add known PMU events



> On Jun 18, 2024, at 22:03, Marc Zyngier <maz@...nel.org> wrote:
> 
> On Tue, 18 Jun 2024 14:49:48 +0100,
> Yangyu Chen <cyy@...self.name> wrote:
>> 
>> This patch adds known PMU events that can be found on /usr/share/kpep in
>> macOS. The m1_pmu_events and m1_pmu_event_affinity are generated from
>> the script [1], which consumes the plist file from Apple. And then added
>> these events to m1_pmu_perf_map and m1_pmu_event_attrs with Apple's
>> documentation [2].
>> 
>> Link: https://github.com/cyyself/m1-pmu-gen [1]
>> Link: https://developer.apple.com/download/apple-silicon-cpu-optimization-guide/ [2]
> 
> This needs registration, and is thus impossible to freely visit.
> 
>> Signed-off-by: Yangyu Chen <cyy@...self.name>
> 
> What is the licence applicable to the original source file? Does it
> explicitly allow redistribution in any form?
> 

Oh. It's my fault. Sorry for the trouble caused.

> 
> Other than the licensing concern, why should we bloat the kernel with
> more of this stuff when everything is moving towards a bunch of JSON
> files (tools/perf/pmu-events/arch/arm64).
> 

Thanks for this hint. So, the thing to do might be to provide a
generator that consumes Apple files and then generates a kernel
patch for Linux perf tools to use rather than provide such details
directly in the source code as you said from [1].

Link: https://lore.kernel.org/lkml/87czn18zev.wl-maz@kernel.org/ [1]

> M.
> 
> -- 
> Without deviation from the norm, progress is not possible.