linux-kernel - Re: [PATCH v10 04/38] pinctrl: add a Cirrus ep93xx SoC pin controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Tue, 18 Jun 2024 19:29:17 +0300
From: Nikita Shubin <nikita.shubin@...uefel.me>
To: Linus Walleij <linus.walleij@...aro.org>
Cc: linux-kernel@...r.kernel.org, linux-gpio@...r.kernel.org, Arnd Bergmann
	 <arnd@...db.de>
Subject: Re: [PATCH v10 04/38] pinctrl: add a Cirrus ep93xx SoC pin
 controller

Hello Linus!

On Tue, 2024-06-18 at 12:27 +0200, Linus Walleij wrote:
> On Mon, Jun 17, 2024 at 11:38 AM Nikita Shubin via B4 Relay
> <devnull+nikita.shubin.maquefel.me@...nel.org> wrote:
> 
> > From: Nikita Shubin <nikita.shubin@...uefel.me>
> > 
> > Add a pin control (only multiplexing) driver for ep93xx SoC so
> > we can fully convert ep93xx to device tree.
> > 
> > This driver is capable of muxing ep9301/ep9302/ep9307/ep9312/ep9315
> > variants, this is chosen based on "compatible" in device tree.
> > 
> > Co-developed-by: Alexander Sverdlin <alexander.sverdlin@...il.com>
> > Signed-off-by: Alexander Sverdlin <alexander.sverdlin@...il.com>
> > Signed-off-by: Nikita Shubin <nikita.shubin@...uefel.me>
> > Reviewed-by: Linus Walleij <linus.walleij@...aro.org>
> 
> Is this patch dependent on the other patches or something I can just
> apply?

Well... it won't work without DT and:

- ARM: ep93xx: add regmap aux_dev
- soc: Add SoC driver for Cirrus ep93xx

And the above will complain if

- dt-bindings: soc: Add Cirrus EP93xx

is missing.

It's harmless and won't be compiled with current platform code, but
will fail to compile if "ARM: ep93xx: add regmap aux_dev" is missing.


> 
> Yours,
> Linus Walleij