linux-kernel - Re: [PATCH 1/3] media: rockchip: Introduce the rkvdec2 driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0e8561108c4fc99291ad7cdc0c6af2dbb8e58f02.camel@ndufresne.ca>
Date: Tue, 18 Jun 2024 12:34:07 -0400
From: Nicolas Dufresne <nicolas@...fresne.ca>
To: Detlev Casanova <detlev.casanova@...labora.com>, Jianfeng Liu
	 <liujianfeng1994@...il.com>
Cc: alchark@...il.com, andy.yan@...k-chips.com, conor+dt@...nel.org, 
	cristian.ciocaltea@...labora.com, devicetree@...r.kernel.org, 
	didi.debian@...ow.org, dsimic@...jaro.org, gregkh@...uxfoundation.org, 
	heiko@...ech.de, krzk+dt@...nel.org, linux-arm-kernel@...ts.infradead.org, 
	linux-kernel@...r.kernel.org, linux-media@...r.kernel.org, 
	linux-rockchip@...ts.infradead.org, linux-staging@...ts.linux.dev, 
	mchehab@...nel.org, robh@...nel.org, sebastian.reichel@...labora.com
Subject: Re: [PATCH 1/3] media: rockchip: Introduce the rkvdec2 driver

Hi,

Le mardi 18 juin 2024 à 08:39 -0400, Detlev Casanova a écrit :
> On Tuesday, June 18, 2024 8:13:29 A.M. EDT Jianfeng Liu wrote:
> > Hi Detlev,
> > 
> > On Fri, 14 Jun 2024 21:56:27 -0400, Detlev Casanova wrote:
> > > +		.frmsize = {
> > > +			.min_width = 16,
> > > +			.max_width =  65520,
> > > +			.step_width = 16,
> > > +			.min_height = 16,
> > > +			.max_height =  65520,
> > > +			.step_height = 16,
> > > +		},
> > 
> > I think the min/max width/height are incorrect. From rockchip's TRM V1.0
> > Part1 page 374, supported image size is 64x64 to 65472x65472.
> i,
> Page 374 shows the sizes for h265. h264 is the next table, where 16x16 and 
> 65520x65520 is documented.

Just a theory, but 64x64 looks like Mali GPU requirement to me. Can you give
more details how it fails exactly ?

Meanwhile, if fluster suite does not exercise it already, we can craft a stream
to verify the its decodes fine. We also have issues in rkvdec were the driver
reports CAPTURE queue constraints for OUTPUT formats.

Nicolas

> 
> > And my
> > chromium can't use rkvdec2 because min width/height are set to 16, which
> > 
> > will cause error at here in rkvdec2_h264_validate_sps:
> > > +	if (width > ctx->coded_fmt.fmt.pix_mp.width ||
> > > +	    height > ctx->coded_fmt.fmt.pix_mp.height)
> > > +		return -EINVAL;
> > 
> > width is 16, height is 32 while ctx->coded_fmt.fmt.pix_mp.width and
> > ctx->coded_fmt.fmt.pix_mp.height are both 16.
> 
> Maybe
> 
> if (!(sps->flags & V4L2_H264_SPS_FLAG_FRAME_MBS_ONLY))
> 	height *= 2;
> 
> is causing issues in this case, I can check.
> 
> > After changing them to 64 my chromium can use rkvdec2 to decode h264
> > videos now.
> > 
> > Anyway many thanks to your amazing work!
> > 
> > Best regards,
> > Jianfeng
>