linux-kernel - [PATCH v4 0/9] Add Mule MFD support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite for Android: free password hash cracker in your pocket
[<prev] [next>] [thread-next>] [day] [month] [year] [list]
Date: Tue, 18 Jun 2024 18:06:42 +0200
From: Farouk Bouabid <farouk.bouabid@...rry.de>
To: Jean Delvare <jdelvare@...e.com>, Guenter Roeck <linux@...ck-us.net>, 
 Andi Shyti <andi.shyti@...nel.org>, Rob Herring <robh@...nel.org>, 
 Krzysztof Kozlowski <krzk+dt@...nel.org>, 
 Conor Dooley <conor+dt@...nel.org>, Lee Jones <lee@...nel.org>, 
 Farouk Bouabid <farouk.bouabid@...rry.de>, 
 Quentin Schulz <quentin.schulz@...rry.de>, Peter Rosin <peda@...ntia.se>, 
 Heiko Stuebner <heiko@...ech.de>
Cc: linux-hwmon@...r.kernel.org, linux-kernel@...r.kernel.org, 
 linux-i2c@...r.kernel.org, devicetree@...r.kernel.org, 
 linux-arm-kernel@...ts.infradead.org, linux-rockchip@...ts.infradead.org
Subject: [PATCH v4 0/9] Add Mule MFD support

Mule is an MCU that emulates a set of I2C devices which are reachable
through an I2C-mux.

The mux and amc6821 combined make the Mule multi-function device (@0x18)

The devices on the mux can be selected by writing the appropriate
device number to an I2C config register (0xff) that is not used by
amc6821 logic.

The selected device on the mux can be accessed for reading and writing
at I2C address 0x6f.

      +--------+----------------+------------------------------+
      |  Mule         (MFD)                                    |
 0x18 |        +----------------+                              |
--------+----->|    amc6821     |                              |
      | |      +----------------+                              |
      | +----->| Mux config reg |-----+                        |
      |        +----------------+     |                        |
      |                               V__          +---------+ |
      |                              |   \-------->| isl1208 | |
      |                              |   |         +---------+ |
 0x6f |                              | M |-------->| dev #1  | |
------------------------------------>| U |         +---------+ |
      |                              | X |-------->| dev #2  | |
      |                              |   |         +---------+ |
      |                              |   /-------->| dev #3  | |
      |                              |__/          +---------+ |
      +--------------------------------------------------------+

This patch-series adds support for the Mule MFD and I2C multiplexer
as part of rk3399-puma, px30-ringneck, rk3588-tiger and rk3588-jaguar
boards.

Signed-off-by: Farouk Bouabid <farouk.bouabid@...rry.de>

Changes in v4:
- Drop the previously added i2c adapter quirks
- Add platform driver probe to amc6821.
- Change mule-i2c-mux driver to a platform driver
- Add dev_probe_err in mule-i2c-mux driver
- Add support for tsd,mule in simple-mfd-i2c
- Add tsd,mule mfd to supported dts

- Link to v3: https://lore.kernel.org/r/20240611-dev-mule-i2c-mux-v3-0-08d26a28e001@cherry.de

Changes in v3:
- Change "i2c" in comments/commit-logs to "I2C"
- Fix long line-length
- Warn when "share_addr_with_children" is set and the Mux is not an I2C device
- Fix/stop propagating "I2C_AQ_SKIP_ADDR_CHECK" flag if "share_addr_with_children"
  is not set.
- Fix "old_fw" variable is used to indicate the reversed meaning.

- Link to v2: https://lore.kernel.org/r/20240506-dev-mule-i2c-mux-v2-0-a91c954f65d7@cherry.de

Changes in v2:
- Add i2c-adapter quirks to skip checking for conflict between the mux core
  and a child device address.
- Rename dt-binding to "tsd,mule-i2c-mux.yaml"
- Add Mule description to kconfig
- Fix indentation
- Move device table after probe

- Link to v1: https://lore.kernel.org/r/20240426-dev-mule-i2c-mux-v1-0-045a482f6ffb@theobroma-systems.com

---
Farouk Bouabid (9):
      hwmon: (amc6821) add platform driver probe
      hwmon: (amc6821) dev_err using amc6821 device struct
      dt-bindings: mfd: add support for mule
      i2c: muxes: add support for mule i2c multiplexer
      mfd: simple-mfd-i2c: Add support for tsd,mule
      arm64: dts: rockchip: add mule mfd (0x18) on rk3588-jaguar
      arm64: dts: rockchip: add mule mfd (0x18) on rk3399-puma
      arm64: dts: rockchip: add mule mfd (0x18) on rk3588-tiger
      arm64: dts: rockchip: add mule mfd (0x18) on px30-ringneck

 .../devicetree/bindings/i2c/tsd,mule-i2c-mux.yaml  |  48 +++++++
 .../devicetree/bindings/mfd/tsd,mule.yaml          |  82 +++++++++++
 arch/arm64/boot/dts/rockchip/px30-ringneck.dtsi    |  33 ++++-
 arch/arm64/boot/dts/rockchip/rk3399-puma.dtsi      |  33 ++++-
 arch/arm64/boot/dts/rockchip/rk3588-jaguar.dts     |  34 ++++-
 arch/arm64/boot/dts/rockchip/rk3588-tiger.dtsi     |  32 ++++-
 drivers/hwmon/amc6821.c                            |  88 +++++++-----
 drivers/i2c/muxes/Kconfig                          |  17 +++
 drivers/i2c/muxes/Makefile                         |   1 +
 drivers/i2c/muxes/i2c-mux-mule.c                   | 151 +++++++++++++++++++++
 drivers/mfd/simple-mfd-i2c.c                       |   1 +
 11 files changed, 461 insertions(+), 59 deletions(-)
---
base-commit: 915c5c8d4bc3c72020b9526cb3cbbd8e14318fc4
change-id: 20240404-dev-mule-i2c-mux-9103cde07021

Best regards,
-- 
Farouk Bouabid <farouk.bouabid@...rry.de>