linux-kernel - Re: [PATCH] context_tracking: Tag context_tracking_enabled_this_cpu() __always

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <12a4224d-64b0-4963-bf6e-c3050d4f9363@paulmck-laptop>
Date: Tue, 18 Jun 2024 11:08:39 -0700
From: "Paul E. McKenney" <paulmck@...nel.org>
To: Sean Christopherson <seanjc@...gle.com>
Cc: Frederic Weisbecker <frederic@...nel.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] context_tracking: Tag
 context_tracking_enabled_this_cpu() __always_inline

On Mon, Jun 17, 2024 at 08:51:14AM -0700, Sean Christopherson wrote:
> Force context_tracking_enabled_this_cpu() to be inlined so that invoking
> it from guest_context_enter_irqoff(), which KVM uses in non-instrumentable
> code, doesn't unexpectedly leave a noinstr section.
> 
>   vmlinux.o: warning: objtool: vmx_vcpu_enter_exit+0x1c7: call to
>     context_tracking_enabled_this_cpu() leaves .noinstr.text section
>   vmlinux.o: warning: objtool: svm_vcpu_enter_exit+0x83: call to
>     context_tracking_enabled_this_cpu() leaves .noinstr.text section
> 
> Note, the CONFIG_CONTEXT_TRACKING_USER=n stub is already __always_inline.
> 
> Signed-off-by: Sean Christopherson <seanjc@...gle.com>

Thank you, Sean, I have queued this for further review and testing.

						Thanx, Paul

> ---
>  include/linux/context_tracking_state.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/linux/context_tracking_state.h b/include/linux/context_tracking_state.h
> index bbff5f7f8803..1a23d8c7d8c3 100644
> --- a/include/linux/context_tracking_state.h
> +++ b/include/linux/context_tracking_state.h
> @@ -113,7 +113,7 @@ static __always_inline bool context_tracking_enabled_cpu(int cpu)
>  	return context_tracking_enabled() && per_cpu(context_tracking.active, cpu);
>  }
>  
> -static inline bool context_tracking_enabled_this_cpu(void)
> +static __always_inline bool context_tracking_enabled_this_cpu(void)
>  {
>  	return context_tracking_enabled() && __this_cpu_read(context_tracking.active);
>  }
> 
> base-commit: e4e9e1067138e5620cf0500c3e5f6ebfb9d322c8
> -- 
> 2.45.2.627.g7a2c4fd464-goog
>