linux-kernel - Re: [PATCH v14 2/6] media: imagination: Add E5010 JPEG Encoder driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Tue, 18 Jun 2024 22:46:24 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: David Huang <d-huang@...com>, Devarsh Thakkar <devarsht@...com>,
 linux-media@...r.kernel.org, devicetree@...r.kernel.org,
 linux-rockchip@...ts.infradead.org,
 Benjamin Gaignard <benjamin.gaignard@...labora.com>,
 Conor Dooley <conor+dt@...nel.org>, Hans Verkuil <hverkuil-cisco@...all.nl>,
 Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Mauro Carvalho Chehab <mchehab@...nel.org>, Rob Herring <robh@...nel.org>,
 Sebastian Fricke <sebastian.fricke@...labora.com>
Cc: LKML <linux-kernel@...r.kernel.org>, Andrew Davis <afd@...com>,
 Andrzej Pietrasiewicz <andrzej.p@...labora.com>,
 Aradhya Bhatia <a-bhatia1@...com>, Brandon Brnich <b-brnich@...com>,
 Darren Etheridge <detheridge@...com>, Jai Luthra <j-luthra@...com>,
 Laurent Pinchart <laurent.pinchart@...asonboard.com>,
 Nicolas Dufresne <nicolas@...fresne.ca>, Nishanth Menon <nm@...com>,
 Praneeth Bajjuri <praneeth@...com>, Prasanth Mantena <p-mantena@...com>,
 Vignesh Raghavendra <vigneshr@...com>, Vijay Pothukuchi <vijayp@...com>
Subject: Re: [PATCH v14 2/6] media: imagination: Add E5010 JPEG Encoder driver

…
> +++ b/drivers/media/platform/imagination/e5010-jpeg-enc.c
> @@ -0,0 +1,1741 @@
…
> +static int e5010_release(struct file *file)
> +{
…
> +	mutex_lock(&e5010->mutex);
> +	v4l2_ctrl_handler_free(&ctx->ctrl_handler);
…
> +	kfree(ctx);
> +	mutex_unlock(&e5010->mutex);
> +
> +	return 0;
> +}
…

Would you become interested to apply a statement like “guard(mutex)(&e5010->mutex);”?
https://elixir.bootlin.com/linux/v6.10-rc4/source/include/linux/mutex.h#L196

Regards,
Markus