linux-kernel - Re: [RFT PATCH v2 0/3] hwmon: (spd5118) Various improvements

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c19e8f05-a189-4091-805c-1898de4e1095@gmx.de>
Date: Tue, 18 Jun 2024 22:59:23 +0200
From: Armin Wolf <W_Armin@....de>
To: Guenter Roeck <linux@...ck-us.net>, linux-hwmon@...r.kernel.org
Cc: linux-kernel@...r.kernel.org,
 Wolfram Sang <wsa+renesas@...g-engineering.com>,
 René Rebe <rene@...ctcode.de>,
 Thomas Weißschuh <linux@...ssschuh.net>,
 Stephen Horvath <s.horvath@...look.com.au>,
 Paul Menzel <pmenzel@...gen.mpg.de>, Sasha Kozachuk <skozachuk@...gle.com>,
 John Hamrick <johnham@...gle.com>, Chris Sarra <chrissarra@...gle.com>
Subject: Re: [RFT PATCH v2 0/3] hwmon: (spd5118) Various improvements

Am 18.06.24 um 21:53 schrieb Guenter Roeck:

> The first patch of this series introduces multi-page support using the
> regmap infrastructure. This simplifies the code and improves regmap caching.
>
> The second patch introduces a spd5118-specific regmap bus to implement
> SMBus accesses. This solves a problem seen with i801 I2C controllers
> when writing to the chip. The I2C_FUNC_SMBUS_I2C_BLOCK support implemented
> in those controllers does not work with spd5118 compatible chips, so
> byte-by-byte access needs to be used explicitly.
>
> The third patch adds support for spd5118 compatible chips which follow
> the standard literally and block access to volatile registers if not
> on page 0.
>
> RFT: I was able to test the code on AMD systems using the piix4 I2C
> controller. It needs testing with i801 controllers and with Renesas
> chips.
>
> v2: Added patches 1 and 2; simplified patch 3 to rely on regmap
>      based paging.

Hi,

i also have an AMD system and DRAM chips without the Renesas controller, but still:

Tested-by: Armin Wolf <W_Armin@....de>

> ----------------------------------------------------------------
> Guenter Roeck (3):
>        hwmon: (spd5118) Use regmap to implement paging
>        hwmon: (spd5118) Use spd5118 specific read/write operations
>        hwmon: (spd5118) Add support for Renesas/ITD SPD5118 hub controllers
>
>   drivers/hwmon/Kconfig   |   2 +-
>   drivers/hwmon/spd5118.c | 131 +++++++++++++++++++++++++++++++++++++-----------
>   2 files changed, 102 insertions(+), 31 deletions(-)