linux-kernel - Re: [PATCH v4 05/19] x86/resctrl: Introduce resctrl_file_fflags

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c9c06c1f-a12e-9b73-5808-0761c3a127b0@amd.com>
Date: Tue, 18 Jun 2024 16:03:36 -0500
From: "Moger, Babu" <babu.moger@....com>
To: Reinette Chatre <reinette.chatre@...el.com>, corbet@....net,
 fenghua.yu@...el.com, tglx@...utronix.de, mingo@...hat.com, bp@...en8.de,
 dave.hansen@...ux.intel.com
Cc: x86@...nel.org, hpa@...or.com, paulmck@...nel.org, rdunlap@...radead.org,
 tj@...nel.org, peterz@...radead.org, yanjiewtw@...il.com,
 kim.phillips@....com, lukas.bulwahn@...il.com, seanjc@...gle.com,
 jmattson@...gle.com, leitao@...ian.org, jpoimboe@...nel.org,
 rick.p.edgecombe@...el.com, kirill.shutemov@...ux.intel.com,
 jithu.joseph@...el.com, kai.huang@...el.com, kan.liang@...ux.intel.com,
 daniel.sneddon@...ux.intel.com, pbonzini@...hat.com, sandipan.das@....com,
 ilpo.jarvinen@...ux.intel.com, peternewman@...gle.com,
 maciej.wieczor-retman@...el.com, linux-doc@...r.kernel.org,
 linux-kernel@...r.kernel.org, eranian@...gle.com, james.morse@....com
Subject: Re: [PATCH v4 05/19] x86/resctrl: Introduce resctrl_file_fflags_init
 to initialize fflags

Hi Reinette,

On 6/13/24 19:57, Reinette Chatre wrote:
> Hi Babu,
> 
> Shortlog: "Introduce resctrl_file_fflags_init() ..."

Sure.

> 
> 
> On 5/24/24 5:23 AM, Babu Moger wrote:
>> The functions thread_throttle_mode_init() and mbm_config_rftype_init()
> 
> You can drop "The functions".

Sure.

> 
>> both initialize fflags for resctrl files. Adding the new files will
> 
> "Adding the new files" -> "Adding new files"? (this should be in new
> paragraph)

Sure.

> 
>> involve adding another function to initialize the fflags. All of this
> 
> Solution should be in new paragraph and written in imperative mood.

ok

> 
>> can be simplified by adding a new function resctrl_file_fflags_init()
>> and passing the file name and flags to be initialized.
>>
>> Consolidate multiple fflags initialization into resctrl_file_fflags_init()
>> and remove thread_throttle_mode_init() and mbm_config_rftype_init().
>>
>> Signed-off-by: Babu Moger <babu.moger@....com>
>> ---
> 
> Patch looks good.

-- 
Thanks
Babu Moger