linux-kernel - Re: [PATCH v1] misc: fastrpc: Increase user PD initmem size

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d7fc5318-bd01-46de-b691-8e40387f6b53@quicinc.com>
Date: Tue, 18 Jun 2024 09:52:43 +0530
From: Ekansh Gupta <quic_ekangupt@...cinc.com>
To: Greg KH <gregkh@...uxfoundation.org>
CC: <srinivas.kandagatla@...aro.org>, <linux-arm-msm@...r.kernel.org>,
        <quic_bkumar@...cinc.com>, <linux-kernel@...r.kernel.org>,
        <quic_chennak@...cinc.com>, stable <stable@...nel.org>
Subject: Re: [PATCH v1] misc: fastrpc: Increase user PD initmem size



On 6/17/2024 2:44 PM, Greg KH wrote:
> On Mon, Jun 17, 2024 at 02:20:50PM +0530, Ekansh Gupta wrote:
>> For user PD initialization, initmem is allocated and sent to DSP for
>> initial memory requirements like shell loading. For unsigned PD
>> offloading, current memory size is not sufficient which would
>> result in PD initialization failures. Increase initial memory size
>> to 5MB.
>>
>> Fixes: 7f1f481263c3 ("misc: fastrpc: check before loading process to the DSP")
>> Cc: stable <stable@...nel.org>
>> Signed-off-by: Ekansh Gupta <quic_ekangupt@...cinc.com>
>> ---
>>  drivers/misc/fastrpc.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/misc/fastrpc.c b/drivers/misc/fastrpc.c
>> index 5204fda51da3..11a230af0b10 100644
>> --- a/drivers/misc/fastrpc.c
>> +++ b/drivers/misc/fastrpc.c
>> @@ -38,7 +38,7 @@
>>  #define FASTRPC_INIT_HANDLE	1
>>  #define FASTRPC_DSP_UTILITIES_HANDLE	2
>>  #define FASTRPC_CTXID_MASK (0xFF0)
>> -#define INIT_FILELEN_MAX (2 * 1024 * 1024)
>> +#define INIT_FILELEN_MAX (5 * 1024 * 1024)
> That is still an arbritrary number, why not make it dynamic and properly
> sized to what the hardware needs?  Otherwise you will need to change
> this again in the future, AND you are wasting memory that doesn't need
> this, right?
Thanks for reviewing the change, Greg.

The size is actually passed by user based on requirement which is then checked against this
INIT_FILELEN_MAX. Till now this was hasn't caused any problems but after introducing
unsigned PD, the size requirement got increased which is resulting in failures.

As for memory wastage, any additional memory passed during DSP PD init is used as the
PD heap in DSP, so the memory is not wasted. I'll add this information to the commit message.

--Ekansh
> thanks,
>
> greg k-h