linux-kernel - Re: [PATCH] x86/alternatives, kvm: Fix a couple of CALLs without a frame pointer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Tue, 18 Jun 2024 16:19:48 -0700
From: Sean Christopherson <seanjc@...gle.com>
To: Borislav Petkov <bp@...en8.de>
Cc: Peter Zijlstra <peterz@...radead.org>, kernel test robot <lkp@...el.com>, 
	Josh Poimboeuf <jpoimboe@...nel.org>, oe-kbuild-all@...ts.linux.dev, 
	linux-kernel@...r.kernel.org, x86@...nel.org
Subject: Re: [PATCH] x86/alternatives, kvm: Fix a couple of CALLs without a
 frame pointer

On Tue, Jun 18, 2024, Borislav Petkov wrote:
> Ok, I was able to scratch up this from the whole shebang:
> 
> ---
> From: "Borislav Petkov (AMD)" <bp@...en8.de>
> Date: Tue, 18 Jun 2024 21:57:27 +0200
> 
> objtool complains:
> 
>   arch/x86/kvm/kvm.o: warning: objtool: .altinstr_replacement+0xc5: call without frame pointer save/setup
>   vmlinux.o: warning: objtool: .altinstr_replacement+0x2eb: call without frame pointer save/setup
> 
> Make sure rSP is an output operand to the respective asm() statements.
> 
> The test_cc() hunk courtesy of peterz. Also from him add some helpful
> debugging info to the documentation.
> 
> Reported-by: kernel test robot <lkp@...el.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202406141648.jO9qNGLa-lkp@intel.com/
> Signed-off-by: Borislav Petkov (AMD) <bp@...en8.de>
> ---

Feel free to take this through tip, I'll be flabbergasted if someone sends a patch
that modifies test_cc().

Acked-by: Sean Christopherson <seanjc@...gle.com>