linux-kernel - Re: [PATCH v2] selftests: Add information about TAP conformance in tests

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f28f4dea-f72b-4266-b415-55fed737d073@linuxfoundation.org>
Date: Tue, 18 Jun 2024 17:43:21 -0600
From: Shuah Khan <skhan@...uxfoundation.org>
To: Muhammad Usama Anjum <usama.anjum@...labora.com>,
 Shuah Khan <shuah@...nel.org>, Jonathan Corbet <corbet@....net>
Cc: kernel@...labora.com, linux-kselftest@...r.kernel.org,
 linux-doc@...r.kernel.org, linux-kernel@...r.kernel.org,
 Shuah Khan <skhan@...uxfoundation.org>
Subject: Re: [PATCH v2] selftests: Add information about TAP conformance in
 tests

On 6/12/24 01:27, Muhammad Usama Anjum wrote:
> Although "TAP" word is being used already in documentation, but it hasn't
> been defined in informative way for developers that how to write TAP
> conformant tests and what are the benefits. Write a short brief about it.
> 
> Signed-off-by: Muhammad Usama Anjum <usama.anjum@...labora.com>
> ---
> Changes since v1:
> - Update documentation by modifying and removing sentences

This described what you did which isn't very useful for reviewers.
In the future mention why you made these changes instead. Something
like "addressed review comments by <reviewer's name>"

> ---
>   Documentation/dev-tools/kselftest.rst | 7 +++++++
>   1 file changed, 7 insertions(+)
> 
> diff --git a/Documentation/dev-tools/kselftest.rst b/Documentation/dev-tools/kselftest.rst
> index dcf634e411bd9..f3766e326d1e3 100644
> --- a/Documentation/dev-tools/kselftest.rst
> +++ b/Documentation/dev-tools/kselftest.rst
> @@ -228,6 +228,13 @@ In general, the rules for selftests are
>    * Don't cause the top-level "make run_tests" to fail if your feature is
>      unconfigured.
>   
> + * The output of tests must conform to the TAP standard to ensure high
> +   testing quality and to capture failures/errors with specific details.
> +   The kselftest.h and kselftest_harness.h headers provide wrappers for
> +   outputting test results. These wrappers should be used for pass,
> +   fail, exit, and skip messages. CI systems can easily parse TAP output
> +   messages to detect test results.
> +
>   Contributing new tests (details)
>   ================================
>   

Thank you for this patch. Applied to linux-kselftest next for Linux  6.11-rc1

thanks,
-- Shuah