linux-kernel - Re: [PATCH 0/3] block: m68k: add missing MODULE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Tue, 18 Jun 2024 05:04:17 +0000
From: Chaitanya Kulkarni <chaitanyak@...dia.com>
To: Jeff Johnson <quic_jjohnson@...cinc.com>, Jens Axboe <axboe@...nel.dk>
CC: "linux-block@...r.kernel.org" <linux-block@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"kernel-janitors@...r.kernel.org" <kernel-janitors@...r.kernel.org>
Subject: Re: [PATCH 0/3] block: m68k: add missing MODULE_DESCRIPTION() macros

On 6/17/24 18:13, Jeff Johnson wrote:
> With ARCH=m68k, make allmodconfig && make W=1 C=1 reports:
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/block/amiflop.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/block/ataflop.o
> WARNING: modpost: missing MODULE_DESCRIPTION() in drivers/block/z2ram.o
>
> Since these have traditionally had different commit prefixes, I
> submitted individual patches. Let me know if you want me to squash
> them.
>
> In addition, drivers/block/swim3.c is also missing a
> MODULE_DESCRIPTION(), but I haven't yet actually triggered the
> warning. I need to customize a PPC configuration which enables
> MAC_FLOPPY in order to trigger the warning and verify the fix.
>
> I'll get around to that when I finish the remaining m68k issues.
>
> ---
> Jeff Johnson (3):
>        amiflop: add missing MODULE_DESCRIPTION() macro
>        ataflop: add missing MODULE_DESCRIPTION() macro
>        z2ram: add missing MODULE_DESCRIPTION() macro
>
>   drivers/block/amiflop.c | 1 +
>   drivers/block/ataflop.c | 1 +
>   drivers/block/z2ram.c   | 1 +
>   3 files changed, 3 insertions(+)
> ---
> base-commit: 6ba59ff4227927d3a8530fc2973b80e94b54d58f
> change-id: 20240617-md-m68k-drivers-block-46c301b46f49
>
>

For the series, looks good ...

Reviewed-by: Chaitanya Kulkarni <kch@...dia.com>

-ck