| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Date: Tue, 18 Jun 2024 08:13:44 +0800 From: Chen Wang <unicorn_wang@...look.com> To: Adrian Hunter <adrian.hunter@...el.com>, Chen Wang <unicornxw@...il.com>, aou@...s.berkeley.edu, conor+dt@...nel.org, guoren@...nel.org, inochiama@...look.com, jszhang@...nel.org, krzysztof.kozlowski+dt@...aro.org, palmer@...belt.com, paul.walmsley@...ive.com, robh@...nel.org, ulf.hansson@...aro.org, devicetree@...r.kernel.org, linux-kernel@...r.kernel.org, linux-mmc@...r.kernel.org, linux-riscv@...ts.infradead.org, chao.wei@...hgo.com, haijiao.liu@...hgo.com, xiaoguang.xing@...hgo.com, tingzhu.wang@...hgo.com Subject: Re: [PATCH v3 1/4] mmc: sdhci-of-dwcmshc: adjust positions of helper routines On 2024/6/14 18:16, Adrian Hunter wrote: > On 13/06/24 04:42, Chen Wang wrote: >> From: Chen Wang <unicorn_wang@...look.com> >> >> This patch does not change the logic of the code, but only adjusts >> the positions of some helper functions in the file according to >> categories to facilitate future function search and maintenance. >> >> Category: helper functions (except for driver callback functions >> such as probe/remove/suspend/resume) are divided into two categories: >> >> - dwcmshc level helpers >> - soc level helpers >> >> After the adjustment, these functions will be put together according >> to category. > Please do not move any functions unless it is needed to avoid forward > declaration. > > Unnecessarily churning the code makes backports more difficult and > complicates the code history, so it should be avoided in general. Accepted. [......]
Powered by blists - more mailing lists