linux-kernel - Re: [PATCH] arm64: dts: imx8mp: Fix pgc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Tue, 18 Jun 2024 08:15:41 +0200
From: Alexander Stein <alexander.stein@...tq-group.com>
To: linux-arm-kernel@...ts.infradead.org, Adam Ford <aford173@...il.com>
Cc: aford@...conembedded.com, marex@...x.de, Adam Ford <aford173@...il.com>, Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>, Shawn Guo <shawnguo@...nel.org>, Sascha Hauer <s.hauer@...gutronix.de>, Pengutronix Kernel Team <kernel@...gutronix.de>, Fabio Estevam <festevam@...il.com>, Peng Fan <peng.fan@....com>, Marco Felsch <m.felsch@...gutronix.de>, devicetree@...r.kernel.org, imx@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] arm64: dts: imx8mp: Fix pgc_mlmix location

Hi Adam,

Am Dienstag, 18. Juni 2024, 00:39:51 CEST schrieb Adam Ford:
> The pgc_mlmix shows a power-domain@24, but the reg value is
> IMX8MP_POWER_DOMAIN_MLMIX which is set to 4.
> 
> The stuff after the @ symbol should match the stuff referenced
> by 'reg' so reorder the pgc_mlmix so it to appear as power-domain@4.

Taking a look this mismatch seems to be also true for:
* IMX8MP_POWER_DOMAIN_VPUMIX
* IMX8MP_POWER_DOMAIN_VPU_G1
* IMX8MP_POWER_DOMAIN_VPU_G2
* IMX8MP_POWER_DOMAIN_VPU_VC8000E

Would you mind fixing them as well?

Despite that, for this patch:
Reviewed-by: Alexander Stein <alexander.stein@...tq-group.com>

Thanks and best regards,
Alexander

> Fixes: 834464c8504c ("arm64: dts: imx8mp: add mlmix power domain")
> Fixes: 4bedc468b725 ("arm64: dts: imx8mp: Add NPU Node")
> 
> Signed-off-by: Adam Ford <aford173@...il.com>
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx8mp.dtsi b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> index b92abb5a5c53..3576d2b89b43 100644
> --- a/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8mp.dtsi
> @@ -789,6 +789,23 @@ pgc_usb2_phy: power-domain@3 {
>  						reg = <IMX8MP_POWER_DOMAIN_USB2_PHY>;
>  					};
>  
> +					pgc_mlmix: power-domain@4 {
> +						#power-domain-cells = <0>;
> +						reg = <IMX8MP_POWER_DOMAIN_MLMIX>;
> +						clocks = <&clk IMX8MP_CLK_ML_AXI>,
> +							 <&clk IMX8MP_CLK_ML_AHB>,
> +							 <&clk IMX8MP_CLK_NPU_ROOT>;
> +						assigned-clocks = <&clk IMX8MP_CLK_ML_CORE>,
> +								  <&clk IMX8MP_CLK_ML_AXI>,
> +								  <&clk IMX8MP_CLK_ML_AHB>;
> +						assigned-clock-parents = <&clk IMX8MP_SYS_PLL1_800M>,
> +									 <&clk IMX8MP_SYS_PLL1_800M>,
> +									 <&clk IMX8MP_SYS_PLL1_800M>;
> +						assigned-clock-rates = <800000000>,
> +								       <800000000>,
> +								       <300000000>;
> +					};
> +
>  					pgc_audio: power-domain@5 {
>  						#power-domain-cells = <0>;
>  						reg = <IMX8MP_POWER_DOMAIN_AUDIOMIX>;
> @@ -900,23 +917,6 @@ pgc_vpu_vc8000e: power-domain@22 {
>  						reg = <IMX8MP_POWER_DOMAIN_VPU_VC8000E>;
>  						clocks = <&clk IMX8MP_CLK_VPU_VC8KE_ROOT>;
>  					};
> -
> -					pgc_mlmix: power-domain@24 {
> -						#power-domain-cells = <0>;
> -						reg = <IMX8MP_POWER_DOMAIN_MLMIX>;
> -						clocks = <&clk IMX8MP_CLK_ML_AXI>,
> -							 <&clk IMX8MP_CLK_ML_AHB>,
> -							 <&clk IMX8MP_CLK_NPU_ROOT>;
> -						assigned-clocks = <&clk IMX8MP_CLK_ML_CORE>,
> -								  <&clk IMX8MP_CLK_ML_AXI>,
> -								  <&clk IMX8MP_CLK_ML_AHB>;
> -						assigned-clock-parents = <&clk IMX8MP_SYS_PLL1_800M>,
> -									 <&clk IMX8MP_SYS_PLL1_800M>,
> -									 <&clk IMX8MP_SYS_PLL1_800M>;
> -						assigned-clock-rates = <800000000>,
> -								       <800000000>,
> -								       <300000000>;
> -					};
>  				};
>  			};
>  		};
> 


-- 
TQ-Systems GmbH | Mühlstraße 2, Gut Delling | 82229 Seefeld, Germany
Amtsgericht München, HRB 105018
Geschäftsführer: Detlef Schneider, Rüdiger Stahl, Stefan Schneider
http://www.tq-group.com/