linux-kernel - Re: [PATCH RESEND] drm/display: Drop obsolete dependency on COMPILE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240618092048.510215ff@endymion.delvare>
Date: Tue, 18 Jun 2024 09:20:48 +0200
From: Jean Delvare <jdelvare@...e.de>
To: Doug Anderson <dianders@...omium.org>
Cc: Dmitry Baryshkov <dmitry.baryshkov@...aro.org>,
 dri-devel@...ts.freedesktop.org, LKML <linux-kernel@...r.kernel.org>,
 Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>, Maxime Ripard
 <mripard@...nel.org>, Thomas Zimmermann <tzimmermann@...e.de>, David Airlie
 <airlied@...il.com>, Daniel Vetter <daniel@...ll.ch>, Andrew Morton
 <akpm@...ux-foundation.org>, YueHaibing <yuehaibing@...wei.com>
Subject: Re: [PATCH RESEND] drm/display: Drop obsolete dependency on
 COMPILE_TEST

Hi Doug,

On Mon, 17 Jun 2024 19:12:05 -0700, Doug Anderson wrote:
> On Mon, Jun 17, 2024 at 3:26 PM Dmitry Baryshkov
> <dmitry.baryshkov@...aro.org> wrote:
> >
> > On Mon, Jun 17, 2024 at 08:18:14PM GMT, Jean Delvare wrote:  
> > > The major difference is that one can't possibly enable ARCH_QCOM if
> > > building on X86 for example. Therefore COMPILE_TEST is the only way to
> > > let everyone (including randconfig/allmodconfig build farms) test-build
> > > your code.
> > >
> > > On the other hand, if you want to test-build drm_dp_aux_bus, you can
> > > simply enable OF, because it is available on all architectures and
> > > doesn't depend on anything. No need for COMPILE_TEST.  
> >
> > I'd probably let Doug respond, what was his intention.  
> 
> Is this me? This looks like a straight revert of commit 876271118aa4
> ("drm/display: Fix build error without CONFIG_OF")
> 
> I don't personally have anything against removing COMPILE_TEST for
> this given that I wasn't the one who added it, but make sure it's not
> going to cause randconfig issues.

Thanks for pointing this commit to my attention, I wasn't aware. This
means that my proposed patch is incomplete and would indeed break
randconfig. I'll send a v2.

-- 
Jean Delvare
SUSE L3 Support