linux-kernel - Re: [PATCH v6 06/24] dma-heap: Add proper kref handling on dma-buf heaps

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <ad8716ac-cff3-4fe5-86e1-f5f188e8b6b1@web.de>
Date: Tue, 18 Jun 2024 09:22:03 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: John Stultz <jstultz@...gle.com>, "T. J. Mercier" <tjmercier@...gle.com>,
 Yong Wu <yong.wu@...iatek.com>, Yunfei Dong <yunfei.dong@...iatek.com>,
 Project_Global_Chrome_Upstream_Group@...iatek.com,
 linux-mediatek@...ts.infradead.org, linux-media@...r.kernel.org,
 dri-devel@...ts.freedesktop.org, linux-arm-kernel@...ts.infradead.org,
 Angelo Gioacchino Del Regno <angelogioacchino.delregno@...labora.com>,
 Benjamin Gaignard <benjamin.gaignard@...labora.com>,
 Hans Verkuil <hverkuil-cisco@...all.nl>,
 Jeffrey Kardatzke <jkardatzke@...gle.com>,
 Marek Szyprowski <m.szyprowski@...sung.com>,
 Mauro Carvalho Chehab <mchehab@...nel.org>,
 Nathan Hebert <nhebert@...omium.org>,
 Nicolas Dufresne <nicolas.dufresne@...labora.com>,
 Nícolas F. R. A. Prado <nfraprado@...labora.com>,
 Sebastian Fricke <sebastian.fricke@...labora.com>,
 Tomasz Figa <tfiga@...omium.org>
Cc: LKML <linux-kernel@...r.kernel.org>, Brian Starkey
 <Brian.Starkey@....com>, Chen-Yu Tsai <wenst@...omium.org>,
 Christian König <christian.koenig@....com>,
 Daniel Vetter <daniel@...ll.ch>, Fritz König
 <frkoenig@...omium.org>, Hsin-Yi Wang <hsinyi@...omium.org>,
 Matthias Brugger <matthias.bgg@...il.com>, Simon Horman <horms@...nel.org>,
 Steve Cho <stevecho@...omium.org>, Sumit Semwal <sumit.semwal@...aro.org>
Subject: Re: [PATCH v6 06/24] dma-heap: Add proper kref handling on dma-buf
 heaps

> Add proper refcounting on the dma_heap structure.

             reference counting?

> While existing heaps are built-in, we may eventually
> have heaps loaded from modules, and we'll need to be
> able to properly handle the references to the heaps

You may occasionally put more than 52 characters into text lines
of such a change description.

…
> +++ b/drivers/dma-buf/dma-heap.c
…
> +static void dma_heap_release(struct kref *ref)
> +{
…
> +	mutex_lock(&heap_list_lock);
> +	list_del(&heap->list);
> +	mutex_unlock(&heap_list_lock);
…

Would you become interested to apply a statement like “guard(mutex)(&heap_list_lock);”?
https://elixir.bootlin.com/linux/v6.10-rc4/source/include/linux/mutex.h#L196

Regards,
Markus