linux-kernel - Re: [PATCH v2] tty: serial: 8250: Fix port count mismatch with the device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Tue, 18 Jun 2024 15:33:12 +0800
From: Crescent CY Hsieh <crescentcy.hsieh@...a.com>
To: Andy Shevchenko <andy.shevchenko@...il.com>
Cc: Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Jiri Slaby <jirislaby@...nel.org>, linux-kernel@...r.kernel.org,
	linux-serial@...r.kernel.org
Subject: Re: [PATCH v2] tty: serial: 8250: Fix port count mismatch with the
 device

On Mon, Jun 17, 2024 at 12:54:34PM +0200, Andy Shevchenko wrote:
> On Mon, Jun 17, 2024 at 8:31 AM Crescent Hsieh
> <crescentcy.hsieh@...a.com> wrote:
> >
> > Normally, the number of ports is indicated by the third digit of the
> > device ID on Moxa PCI serial boards. For example, `0x1121` indicates a
> > device with 2 ports.
> >
> > However, `CP116E_A_A` and `CP116E_A_B` are exceptions; they have 8
> > ports, but the third digit of the device ID is `6`.
> >
> > This patch introduces a function to retrieve the number of ports on Moxa
> > PCI serial boards, addressing the issue described above.
> 
> Now it makes sense to me.
> Reviewed-by: Andy Shevchenko <andy@...nel.org>

Thanks for your review, suggestions and explanation.

---
Sincerely,
Crescent Hsieh