linux-kernel - Re: [PATCH] drm/lima: Mark simple

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240618-great-hissing-skink-b7950e@houat>
Date: Tue, 18 Jun 2024 10:13:47 +0200
From: Maxime Ripard <mripard@...nel.org>
To: Qiang Yu <yuq825@...il.com>
Cc: Dragan Simic <dsimic@...jaro.org>, dri-devel@...ts.freedesktop.org, 
	lima@...ts.freedesktop.org, maarten.lankhorst@...ux.intel.com, tzimmermann@...e.de, 
	airlied@...il.com, daniel@...ll.ch, linux-kernel@...r.kernel.org, 
	Philip Muller <philm@...jaro.org>, Oliver Smith <ollieparanoid@...tmarketos.org>, 
	Daniel Smith <danct12@...root.org>, stable@...r.kernel.org
Subject: Re: [PATCH] drm/lima: Mark simple_ondemand governor as softdep

On Tue, Jun 18, 2024 at 04:01:26PM GMT, Qiang Yu wrote:
> On Tue, Jun 18, 2024 at 12:33 PM Qiang Yu <yuq825@...il.com> wrote:
> >
> > I see the problem that initramfs need to build a module dependency chain,
> > but lima does not call any symbol from simpleondemand governor module.
> >
> > softdep module seems to be optional while our dependency is hard one,
> > can we just add MODULE_INFO(depends, _depends), or create a new
> > macro called MODULE_DEPENDS()?
> >
> This doesn't work on my side because depmod generates modules.dep
> by symbol lookup instead of modinfo section. So softdep may be our only
> choice to add module dependency manually. I can accept the softdep
> first, then make PM optional later.

It's still super fragile, and depends on the user not changing the
policy. It should be solved in some other, more robust way.

Maxime

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)