linux-kernel - Re: [PATCH v7 net-next 15/15] net: Move per-CPU flush-lists to bpf_net_context on PREEMPT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3f0fb527-ac58-4f73-b4f1-1e35bf064feb@kernel.org>
Date: Tue, 18 Jun 2024 10:17:42 +0200
From: Jesper Dangaard Brouer <hawk@...nel.org>
To: Sebastian Andrzej Siewior <bigeasy@...utronix.de>,
 linux-kernel@...r.kernel.org, netdev@...r.kernel.org
Cc: "David S. Miller" <davem@...emloft.net>,
 Daniel Bristot de Oliveira <bristot@...nel.org>,
 Boqun Feng <boqun.feng@...il.com>, Daniel Borkmann <daniel@...earbox.net>,
 Eric Dumazet <edumazet@...gle.com>, Frederic Weisbecker
 <frederic@...nel.org>, Ingo Molnar <mingo@...hat.com>,
 Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
 Peter Zijlstra <peterz@...radead.org>, Thomas Gleixner <tglx@...utronix.de>,
 Waiman Long <longman@...hat.com>, Will Deacon <will@...nel.org>,
 Björn Töpel <bjorn@...nel.org>,
 Alexei Starovoitov <ast@...nel.org>, Andrii Nakryiko <andrii@...nel.org>,
 Eduard Zingerman <eddyz87@...il.com>, Hao Luo <haoluo@...gle.com>,
 Jiri Olsa <jolsa@...nel.org>, John Fastabend <john.fastabend@...il.com>,
 Jonathan Lemon <jonathan.lemon@...il.com>, KP Singh <kpsingh@...nel.org>,
 Maciej Fijalkowski <maciej.fijalkowski@...el.com>,
 Magnus Karlsson <magnus.karlsson@...el.com>,
 Martin KaFai Lau <martin.lau@...ux.dev>, Song Liu <song@...nel.org>,
 Stanislav Fomichev <sdf@...gle.com>, Toke Høiland-Jørgensen <toke@...hat.com>, Yonghong Song <yonghong.song@...ux.dev>,
 bpf@...r.kernel.org
Subject: Re: [PATCH v7 net-next 15/15] net: Move per-CPU flush-lists to
 bpf_net_context on PREEMPT_RT.

On 18/06/2024 09.13, Sebastian Andrzej Siewior wrote:
> The per-CPU flush lists, which are accessed from within the NAPI callback
> (xdp_do_flush() for instance), are per-CPU. There are subject to the
> same problem as struct bpf_redirect_info.
> 
> Add the per-CPU lists cpu_map_flush_list, dev_map_flush_list and
> xskmap_map_flush_list to struct bpf_net_context. Add wrappers for the
> access. The lists initialized on first usage (similar to
> bpf_net_ctx_get_ri()).
> 
> Cc: "Björn Töpel"<bjorn@...nel.org>
> Cc: Alexei Starovoitov<ast@...nel.org>
> Cc: Andrii Nakryiko<andrii@...nel.org>
> Cc: Eduard Zingerman<eddyz87@...il.com>
> Cc: Hao Luo<haoluo@...gle.com>
> Cc: Jesper Dangaard Brouer<hawk@...nel.org>
> Cc: Jiri Olsa<jolsa@...nel.org>
> Cc: John Fastabend<john.fastabend@...il.com>
> Cc: Jonathan Lemon<jonathan.lemon@...il.com>
> Cc: KP Singh<kpsingh@...nel.org>
> Cc: Maciej Fijalkowski<maciej.fijalkowski@...el.com>
> Cc: Magnus Karlsson<magnus.karlsson@...el.com>
> Cc: Martin KaFai Lau<martin.lau@...ux.dev>
> Cc: Song Liu<song@...nel.org>
> Cc: Stanislav Fomichev<sdf@...gle.com>
> Cc: Toke Høiland-Jørgensen<toke@...hat.com>
> Cc: Yonghong Song<yonghong.song@...ux.dev>
> Cc:bpf@...r.kernel.org
> Reviewed-by: Toke Høiland-Jørgensen<toke@...hat.com>
> Signed-off-by: Sebastian Andrzej Siewior<bigeasy@...utronix.de>

Acked-by: Jesper Dangaard Brouer <hawk@...nel.org>

> ---
>   include/linux/filter.h | 42 ++++++++++++++++++++++++++++++++++++++++++
>   kernel/bpf/cpumap.c    | 19 +++----------------
>   kernel/bpf/devmap.c    | 11 +++--------
>   net/xdp/xsk.c          | 12 ++++--------
>   4 files changed, 52 insertions(+), 32 deletions(-)