linux-kernel - Re: [PATCH v6 4/6] media: hantro: Add RK3588 VEPU121

Open Source and information security mailing list archives

Message-ID: <2e98128f-39f8-4800-91f6-c1cfa21fa0a6@gmail.com>
Date: Tue, 18 Jun 2024 10:28:14 +0200
From: Alex Bee <knaerzche@...il.com>
To: Sebastian Reichel <sebastian.reichel@...labora.com>,
 Jianfeng Liu <liujianfeng1994@...il.com>
Cc: conor+dt@...nel.org, devicetree@...r.kernel.org,
 ezequiel@...guardiasur.com.ar, frattaroli.nicolas@...il.com,
 heiko@...ech.de, kernel@...labora.com, krzk+dt@...nel.org,
 linkmauve@...kmauve.fr, linux-kernel@...r.kernel.org,
 linux-media@...r.kernel.org, linux-rockchip@...ts.infradead.org,
 nicolas.dufresne@...labora.com, p.zabel@...gutronix.de, robh@...nel.org
Subject: Re: [PATCH v6 4/6] media: hantro: Add RK3588 VEPU121

Am 17.06.24 um 13:30 schrieb Sebastian Reichel:
> Hi,
> 
> On Mon, Jun 17, 2024 at 10:50:22AM GMT, Jianfeng Liu wrote:
>> Hi Sebastian,
>>
>> Thu, 13 Jun 2024 15:48:45 +0200, Sebastian Reichel wrote:
>>> +	{ .compatible = "rockchip,rk3588-vepu121", .data = &rk3568_vpu_variant, },
>>
>> rk3568_vpu_variant is decoder's data, typo?
> 
> See first sentence of the commit message.
> 
I think, what Jianfeng meant, is that you are incorrectly using
rk3568_vpu_variant for the newly added "rockchip,rk3588-vepu121"
compatible: rk3568_vpu_variant is for the decoder (confusing, I know:
should actually be rk3568_vdpu_variant) - you want to use
rk3568_vepu_variant instead for it instead.

Alex
> -- Sebastian.
> 
> 
> _______________________________________________
> Linux-rockchip mailing list
> Linux-rockchip@...ts.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-rockchip

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives