linux-kernel - [PATCH 1/2] tools: kernel-chktaint: Fix bashism, simplify code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240618090641.359008-1-pvorel@suse.cz>
Date: Tue, 18 Jun 2024 11:06:40 +0200
From: Petr Vorel <pvorel@...e.cz>
To: linux-kernel@...r.kernel.org
Cc: Petr Vorel <pvorel@...e.cz>,
	Randy Dunlap <rdunlap@...radead.org>,
	Thorsten Leemhuis <linux@...mhuis.info>,
	Jonathan Corbet <corbet@....net>,
	Jiri Olsa <jolsa@...nel.org>,
	Shuah Khan <skhan@...uxfoundation.org>,
	linux-kselftest@...r.kernel.org
Subject: [PATCH 1/2] tools: kernel-chktaint: Fix bashism, simplify code

'==' is bashism, '=' needs to be used for comparison.
With this fix script can work on systems where the default shell is
dash, busybox ash or any other strictly POSIX compatible shell.

While at it, also improve:
* remove "x" in the comparison (not needed for decades)
* use $# for checking number of arguments
* cleanup whitespace

Fixes: 4ab5a5d2a4a22 ("tools: add a kernel-chktaint to tools/debugging")
Signed-off-by: Petr Vorel <pvorel@...e.cz>
---
 tools/debugging/kernel-chktaint | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/tools/debugging/kernel-chktaint b/tools/debugging/kernel-chktaint
index 279be06332be9..adbb1d621ccd4 100755
--- a/tools/debugging/kernel-chktaint
+++ b/tools/debugging/kernel-chktaint
@@ -18,11 +18,11 @@ retrieved from /proc/sys/kernel/tainted on another system.
 EOF
 }
 
-if [ "$1"x != "x" ]; then
-	if  [ "$1"x == "--helpx" ] || [ "$1"x == "-hx" ] ; then
+if [ $# -gt 0 ]; then
+	if  [ "$1" = "--help" ] || [ "$1" = "-h" ]; then
 		usage
 		exit 1
-	elif  [ $1 -ge 0 ] 2>/dev/null ; then
+	elif  [ $1 -ge 0 ] 2>/dev/null; then
 		taint=$1
 	else
 		echo "Error: Parameter '$1' not a positive integer. Aborting." >&2
-- 
2.45.1