linux-kernel - Re: [PATCH v3 3/4] mmc: sdhci-of-dwcmshc: extract init function for rk35xx/th1520

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <MA0P287MB2822D6EF7DE3C129AD6FF3B5FECE2@MA0P287MB2822.INDP287.PROD.OUTLOOK.COM>
Date: Tue, 18 Jun 2024 08:04:01 +0800
From: Chen Wang <unicorn_wang@...look.com>
To: Adrian Hunter <adrian.hunter@...el.com>, Chen Wang <unicornxw@...il.com>,
 aou@...s.berkeley.edu, conor+dt@...nel.org, guoren@...nel.org,
 inochiama@...look.com, jszhang@...nel.org,
 krzysztof.kozlowski+dt@...aro.org, palmer@...belt.com,
 paul.walmsley@...ive.com, robh@...nel.org, ulf.hansson@...aro.org,
 devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
 linux-mmc@...r.kernel.org, linux-riscv@...ts.infradead.org,
 chao.wei@...hgo.com, haijiao.liu@...hgo.com, xiaoguang.xing@...hgo.com,
 tingzhu.wang@...hgo.com
Subject: Re: [PATCH v3 3/4] mmc: sdhci-of-dwcmshc: extract init function for
 rk35xx/th1520


On 2024/6/14 18:33, Adrian Hunter wrote:
> On 13/06/24 04:43, Chen Wang wrote:
>> From: Chen Wang <unicorn_wang@...look.com>
[......]
>>
>>
>>   static void cv18xx_sdhci_reset(struct sdhci_host *host, u8 mask)
>>   {
>>   	struct sdhci_pltfm_host *pltfm_host = sdhci_priv(host);
>> @@ -1230,46 +1270,15 @@ static int dwcmshc_probe(struct platform_device *pdev)
>>   	host->mmc_host_ops.execute_tuning = dwcmshc_execute_tuning;
>>   
>>   	if (pltfm_data == &sdhci_dwcmshc_rk35xx_pdata) {
>> -		rk_priv = devm_kzalloc(&pdev->dev, sizeof(struct rk35xx_priv), GFP_KERNEL);
>> -		if (!rk_priv) {
>> -			err = -ENOMEM;
>> -			goto err_clk;
>> -		}
>> -
>> -		if (of_device_is_compatible(pdev->dev.of_node, "rockchip,rk3588-dwcmshc"))
>> -			rk_priv->devtype = DWCMSHC_RK3588;
>> -		else
>> -			rk_priv->devtype = DWCMSHC_RK3568;
>> -
>> -		priv->priv = rk_priv;
>> -
>> -		err = rk35xx_init(host, priv);
>> +		err = rk35xx_init(&pdev->dev, host, priv);
> rk_priv is used further on, but it is not assigned anymore.

You are right. It seems unnecessary to provide this patch separately 
just to extract the init function, and it also violates the principle of 
atomicity of patch modification. I will merge this patch with the next one.

[......]