linux-kernel - Re: [PATCH V5 RESEND 5/5] venus: pm_helpers: Use dev_pm_genpd_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Tue, 18 Jun 2024 15:04:26 +0530
From: Jagadeesh Kona <quic_jkona@...cinc.com>
To: Bryan O'Donoghue <bryan.odonoghue@...aro.org>,
        Konrad Dybcio
	<konrad.dybcio@...aro.org>,
        Bjorn Andersson <andersson@...nel.org>,
        "Michael
 Turquette" <mturquette@...libre.com>,
        Stephen Boyd <sboyd@...nel.org>,
        Stanimir Varbanov <stanimir.k.varbanov@...il.com>,
        Vikash Garodia
	<quic_vgarodia@...cinc.com>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        "Ulf
 Hansson" <ulf.hansson@...aro.org>,
        "Rafael J . Wysocki" <rafael@...nel.org>,
        Kevin Hilman <khilman@...nel.org>, Pavel Machek <pavel@....cz>,
        Len Brown
	<len.brown@...el.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        "Andy
 Gross" <agross@...nel.org>,
        Dmitry Baryshkov <dmitry.baryshkov@...aro.org>,
        Abel Vesa <abel.vesa@...aro.org>
CC: <linux-arm-msm@...r.kernel.org>, <linux-clk@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <linux-media@...r.kernel.org>,
        <linux-pm@...r.kernel.org>, Taniya Das <quic_tdas@...cinc.com>,
        "Satya Priya
 Kakitapalli" <quic_skakitap@...cinc.com>,
        Imran Shaik
	<quic_imrashai@...cinc.com>,
        Ajit Pandey <quic_ajipan@...cinc.com>
Subject: Re: [PATCH V5 RESEND 5/5] venus: pm_helpers: Use
 dev_pm_genpd_set_hwmode to switch GDSC mode on V6



On 6/17/2024 3:21 PM, Bryan O'Donoghue wrote:
> On 17/06/2024 03:31, Jagadeesh Kona wrote:
>>
>>
>> On 5/31/2024 5:26 PM, Jagadeesh Kona wrote:
>>>
>>>
>>> On 5/10/2024 6:31 PM, Bryan O'Donoghue wrote:
>>>> On 01/05/2024 10:14, Bryan O'Donoghue wrote:
>>>>> On 30/04/2024 21:01, Konrad Dybcio wrote:
>>>>>> On 24.04.2024 11:50 AM, Bryan O'Donoghue wrote:
>>>>>>> On 24/04/2024 10:45, Jagadeesh Kona wrote:
>>>>>>>>
>>>>>>>> Thanks Bryan for testing this series. Can you please confirm if 
>>>>>>>> this issue is observed in every run or only seen during the 
>>>>>>>> first run? Also please let me know on which platform this issue 
>>>>>>>> is observed?
>>>>>>>>
>>>>>>>> Thanks,
>>>>>>>> Jagadeesh
>>>>>>>
>>>>>>> rb5/sm8250
>>>>>>>
>>>>>>> My observation was on a previous _boot_ the stuttering was worse. 
>>>>>>> There is in the video capture three times that I count where the 
>>>>>>> video halts briefly, I guess we need to vote or set an OPP so the 
>>>>>>> firmware knows not to power-collapse quite so aggressively.
>>>>>>
>>>>>> We seem to be having some qualcomm-wide variance on perf/pwr usage 
>>>>>> on some
>>>>>> odd boots.. Any chance you could try like 5 times and see if it 
>>>>>> was a fluke?
>>>>>>
>>>>>> Konrad
>>>>>
>>>>> Sure.
>>>>>
>>>>> The first time I tried it, it was much worse.
>>>>>
>>>>> The second time, captured in the video is only noticeable because I 
>>>>> was *looking* for this specific error i.e. I don't think I would 
>>>>> have noticed the error on the second run, had I not seen the first 
>>>>> run.
>>>>>
>>>>> I'll find some time to do 5x with and 5x without.
>>>>>
>>>>> ---
>>>>> bod
>>>>
>>>> ping bod please remember to do this thanks
>>>>
>>>
>>> Hi Bryan, Could you please let me know if you got a chance to check 
>>> the above? Thank you!
>>>
>>
>> Hi Bryan, Kindly can you please help confirm if this is a real issue 
>> or observed as a fluke? so we can go ahead and mainline these changes.
>>
>> Thanks,
>> Jagadeesh
> 
> So I'm happier with this patchset when I run gstreamer instead of ffmpeg.
> 
> There doesn't appear to be a discernable difference between before/after 
> on framerate or subjective UX with/without this set.
> 
> gst-launch-1.0 -vvv -e filesrc location=sample-5s.mp4 ! qtdemux ! 
> parsebin ! v4l2h264dec ! autovideosink
> 
> Tested-by: Bryan O'Donoghue <bryan.odonoghue@...aro.org>

Thanks a lot Bryan for helping with the testing.

Thanks,
Jagadeesh