linux-kernel - Re: [PATCH v2] ACPI /amba: Fix meaningless code for amba_register_dummy

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20240618100016.jmwqoe7aq5ttxjaz@bogus>
Date: Tue, 18 Jun 2024 11:00:16 +0100
From: Sudeep Holla <sudeep.holla@....com>
To: Youwan Wang <youwan@...china.com>
Cc: christophe.jaillet@...adoo.fr, guohanjun@...wei.com,
	linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	Sudeep Holla <sudeep.holla@....com>, lenb@...nel.org
Subject: Re: [PATCH v2] ACPI /amba: Fix meaningless code for
 amba_register_dummy_clk()

On Mon, Jun 17, 2024 at 08:50:44AM +0800, Youwan Wang wrote:
> Defining `amba_dummy_clk` as static is meaningless.
> 
> The amba_register_dummy_clk() function is static and
> is called during initialization. I think 'amba_dummy_clk'
> should be NULL each time when initializing
>

LGTM, can't figure why this was done like this. Looked at v4.6 when this
was introduced, still can't get a clue.

Acked-by: Sudeep Holla <sudeep.holla@....com>

Please check and include all the maintainers correctly and repost this
patch with my ack. I don't understand how you chose the set of people
or list you have included here.

$ ./scripts/get_maintainer.pl -f drivers/acpi/arm64/amba.c

Also please include Catalin and Will who can pick up this patch and
route it through arm64 tree.

-- 
Regards,
Sudeep