linux-kernel - Re: [PATCH 0/7] platform/x86/inte-uncore-freq: Cleanups

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1c180de1-0cad-82c4-b7e9-d951331725d6@linux.intel.com>
Date: Tue, 18 Jun 2024 13:00:26 +0300 (EEST)
From: Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>
To: Tero Kristo <tero.kristo@...ux.intel.com>
cc: Hans de Goede <hdegoede@...hat.com>, srinivas.pandruvada@...ux.intel.com, 
    LKML <linux-kernel@...r.kernel.org>, platform-driver-x86@...r.kernel.org
Subject: Re: [PATCH 0/7] platform/x86/inte-uncore-freq: Cleanups

On Mon, 17 Jun 2024, Tero Kristo wrote:

> Hi,
> 
> This series introduces some cleanups for the code and driver level APIs.
> The purpose is to improve the maintainability of the code and make it
> easier to add new features in future.
> 
> No functional changes expected from any of the patches in this series.

Nice cleanups, thank you.

I've applied these into review-ilpo branch with the following 
modifications:

- I fixed my name on Reviewed-by line. Please don't corrupt my name if
  handwriting a tag instead of copying it. While I don't care that much
  if my name is not always written 100% correctly, an incorrect rev-by 
  line causes my tools to add the correct form one so the rev-by line 
  gets duplicated (luckily I was paying attention to the non-critical 
  part of the output of my tool this time around so I caught it).

- I renamed _min, _max, and _value variables to min, max, and v, 
  respectively, because the reason for using underscores got removed by
  the change.

-- 
 i.