linux-kernel - Re: [PATCH 1/6] wifi: wilc1000: disable power sequencer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <171870624981.452784.17242642371617019106.kvalo@kernel.org>
Date: Tue, 18 Jun 2024 10:24:11 +0000 (UTC)
From: Kalle Valo <kvalo@...nel.org>
To: Alexis Lothoré <alexis.lothore@...tlin.com>
Cc: linux-wireless@...r.kernel.org, Ajay Singh <ajay.kathat@...rochip.com>,
 Claudiu Beznea <claudiu.beznea@...on.dev>,
 Thomas Petazzoni <thomas.petazzoni@...tlin.com>,
 linux-kernel@...r.kernel.org,
 Alexis Lothoré <alexis.lothore@...tlin.com>
Subject: Re: [PATCH 1/6] wifi: wilc1000: disable power sequencer

Alexis Lothoré <alexis.lothore@...tlin.com> wrote:

> From: Ajay Singh <ajay.kathat@...rochip.com>
> 
> Driver systematically disables some power mechanism each time it starts the
> chip firmware (so mostly when interface is brought up). This has a negative
> impact on some specific scenarios when the chip is exposed as a
> hotpluggable SDIO card (eg: WILC1000 SD):
> - when executing suspend/resume sequence while interface has been brought
>   up
> - rebooting the platform while module is plugged and interface has been
>   brought up
> Those scenarios lead to mmc core trying to initialize again the chip which
> is now unresponsive (because of the power sequencer setting), so it fails
> in mmc_rescan->mmc_attach_sdio and enter a failure loop while trying to
> send CMD5:
> mmc0: error -110 whilst initialising SDIO card
> mmc0: error -110 whilst initialising SDIO card
> mmc0: error -110 whilst initialising SDIO card
> [...]
> 
> Preventing the driver from disabling this "power sequencer" fixes those
> enumeration issues without affecting nominal operations.
> 
> Signed-off-by: Ajay Singh <ajay.kathat@...rochip.com>
> Signed-off-by: Alexis Lothoré <alexis.lothore@...tlin.com>

6 patches applied to wireless-next.git, thanks.

70ed0bdab1ca wifi: wilc1000: disable power sequencer
301e44e973eb wifi: wilc1000: let host->chip suspend/resume notifications manage chip wake/sleep
25d086ba1964 wifi: wilc1000: do not keep sdio bus claimed during suspend/resume
a814112e9545 wifi: wilc1000: move sdio suspend method next to resume and pm ops definition
1e9e258d9fb5 wifi: wilc1000: remove suspend/resume from cfg80211 part
5ad8897fd15a wifi: wilc1000: disable SDIO func IRQ before suspend

-- 
https://patchwork.kernel.org/project/linux-wireless/patch/20240613-wilc_suspend-v1-1-c2f766d0988c@bootlin.com/

https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches