linux-kernel - Re: [PATCH 1/2] x86/cpufeatures: Add HWP highest perf change feature flag

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <087eb35754ddd8dde74c55ac7783fe42f48b7f82.camel@linux.intel.com>
Date: Tue, 18 Jun 2024 03:25:11 -0700
From: srinivas pandruvada <srinivas.pandruvada@...ux.intel.com>
To: Borislav Petkov <bp@...en8.de>
Cc: rafael@...nel.org, viresh.kumar@...aro.org, tglx@...utronix.de, 
	mingo@...hat.com, dave.hansen@...ux.intel.com, hpa@...or.com, 
	linux-pm@...r.kernel.org, linux-kernel@...r.kernel.org, x86@...nel.org
Subject: Re: [PATCH 1/2] x86/cpufeatures: Add HWP highest perf change
 feature flag

On Tue, 2024-06-18 at 11:07 +0200, Borislav Petkov wrote:
> On Mon, Jun 17, 2024 at 08:51:20PM -0700, Srinivas Pandruvada wrote:
> > When CPUID[6].EAX[15] is set to 1, this CPU supports notification
> > for
> > HWP (Hardware P-states) highest performance change.
> > 
> > Add a feature flag to check if the CPU supports HWP highest
> > performance
> > change.
> > 
> > 

[...]

> > +#define X86_FEATURE_HWP_HIGHEST_PERF_CHANGE (14*32+15) /* HWP
> > Highest perf change */
> 
> Doesn't belong in /proc/cpuinfo:
> 
> #define X86_FEATURE_HWP_HIGHEST_PERF_CHANGE (14*32+15) /* "" HWP
> Highest perf change */
> 
>                                                         ^^^^^

Thanks for pointing this out. Will update in v2.

-Srinivas

> 
>