linux-kernel - Re: [PATCH 09/15] net: hbl_en: add habanalabs Ethernet driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <df68aa17-c32a-45c5-9198-ea2d9fe2c40b@habana.ai>
Date: Tue, 18 Jun 2024 11:16:03 +0000
From: Omer Shpigelman <oshpigelman@...ana.ai>
To: Zhu Yanjun <yanjun.zhu@...ux.dev>,
        "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>,
        "linux-rdma@...r.kernel.org"
	<linux-rdma@...r.kernel.org>,
        "netdev@...r.kernel.org"
	<netdev@...r.kernel.org>,
        "dri-devel@...ts.freedesktop.org"
	<dri-devel@...ts.freedesktop.org>
CC: "ogabbay@...nel.org" <ogabbay@...nel.org>,
        Zvika Yehudai
	<zyehudai@...ana.ai>
Subject: Re: [PATCH 09/15] net: hbl_en: add habanalabs Ethernet driver

On 6/15/24 13:55, Zhu Yanjun wrote:
> [You don't often get email from yanjun.zhu@...ux.dev. Learn why this is important at https://aka.ms/LearnAboutSenderIdentification ]
>
> 在 2024/6/13 16:22, Omer Shpigelman 写道:
>> +
>> +/* This function should be called after ctrl_lock was taken */
>
> https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/dev-tools/sparse.rst?h=v6.10-rc3#n64
>
> "
> __must_hold - The specified lock is held on function entry and exit.
> "
> Add "__must_hold" to confirm "The specified lock is held on function
> entry and exit." ?
>
> Zhu Yanjun

Thanks, I'll add it.