linux-kernel - Re: [PATCH v3 12/18] media: venus: Refactor struct hfi_session_get_property

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <b5c29e6d-ab5f-9a06-081b-c9911416e86e@quicinc.com>
Date: Tue, 18 Jun 2024 17:48:16 +0530
From: Vikash Garodia <quic_vgarodia@...cinc.com>
To: Ricardo Ribalda <ribalda@...omium.org>,
        Michael Tretter
	<m.tretter@...gutronix.de>,
        Pengutronix Kernel Team <kernel@...gutronix.de>,
        Mauro Carvalho Chehab <mchehab@...nel.org>,
        Laurent Pinchart
	<laurent.pinchart@...asonboard.com>,
        Michal Simek <michal.simek@....com>,
        Andy Walls <awalls@...metrocast.net>,
        Stanimir Varbanov
	<stanimir.k.varbanov@...il.com>,
        Bryan O'Donoghue
	<bryan.odonoghue@...aro.org>,
        Bjorn Andersson <andersson@...nel.org>,
        Konrad
 Dybcio <konrad.dybcio@...aro.org>
CC: <linux-media@...r.kernel.org>, <linux-kernel@...r.kernel.org>,
        <linux-arm-kernel@...ts.infradead.org>,
        <linux-arm-msm@...r.kernel.org>,
        Hans
 Verkuil <hverkuil-cisco@...all.nl>
Subject: Re: [PATCH v3 12/18] media: venus: Refactor struct
 hfi_session_get_property_pkt


On 6/18/2024 5:35 PM, Vikash Garodia wrote:
> 
> On 5/28/2024 2:39 AM, Ricardo Ribalda wrote:
>> The struct hfi_session_get_property_pkt is always used to fectch a
fectch -> fetch

>> single property. Make that explicit in the code and avoid a single
>> element array at the end of the struct.
>>
>> This change fixes the following cocci warning:
>> drivers/media/platform/qcom/venus/hfi_cmds.h:194:5-9: WARNING use flexible-array member instead (https://www.kernel.org/doc/html/latest/process/deprecated.html#zero-length-and-one-element-arrays)
>>
>> Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@...aro.org>
>> Signed-off-by: Ricardo Ribalda <ribalda@...omium.org>
>> ---
>>  drivers/media/platform/qcom/venus/hfi_cmds.c | 4 ++--
>>  drivers/media/platform/qcom/venus/hfi_cmds.h | 2 +-
>>  2 files changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/media/platform/qcom/venus/hfi_cmds.c b/drivers/media/platform/qcom/venus/hfi_cmds.c
>> index 3418d2dd9371..75f4a3d3e748 100644
>> --- a/drivers/media/platform/qcom/venus/hfi_cmds.c
>> +++ b/drivers/media/platform/qcom/venus/hfi_cmds.c
>> @@ -402,7 +402,7 @@ static int pkt_session_get_property_1x(struct hfi_session_get_property_pkt *pkt,
>>  	pkt->shdr.hdr.pkt_type = HFI_CMD_SESSION_GET_PROPERTY;
>>  	pkt->shdr.session_id = hash32_ptr(cookie);
>>  	pkt->num_properties = 1;
>> -	pkt->data[0] = ptype;
>> +	pkt->data = ptype;
>>  
>>  	return 0;
>>  }
>> @@ -1110,7 +1110,7 @@ pkt_session_get_property_3xx(struct hfi_session_get_property_pkt *pkt,
>>  
>>  	switch (ptype) {
>>  	case HFI_PROPERTY_CONFIG_VDEC_ENTROPY:
>> -		pkt->data[0] = HFI_PROPERTY_CONFIG_VDEC_ENTROPY;
>> +		pkt->data = HFI_PROPERTY_CONFIG_VDEC_ENTROPY;
>>  		break;
>>  	default:
>>  		ret = pkt_session_get_property_1x(pkt, cookie, ptype);
>> diff --git a/drivers/media/platform/qcom/venus/hfi_cmds.h b/drivers/media/platform/qcom/venus/hfi_cmds.h
>> index 6dff949c4402..f5708fdfb197 100644
>> --- a/drivers/media/platform/qcom/venus/hfi_cmds.h
>> +++ b/drivers/media/platform/qcom/venus/hfi_cmds.h
>> @@ -191,7 +191,7 @@ struct hfi_session_resume_pkt {
>>  struct hfi_session_get_property_pkt {
>>  	struct hfi_session_hdr_pkt shdr;
>>  	u32 num_properties;
>> -	u32 data[1];
>> +	u32 data;
>>  };
>>  
>>  struct hfi_session_release_buffer_pkt {
>>
> Acked-by: Vikash Garodia <quic_vgarodia@...cinc.com>