linux-kernel - Re: [PATCH v2 3/4] media: dt-bindings: rockchip: Document RK3588 Video Decoder bindings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20240619-contently-demote-769bf48d7eb6@spud>
Date: Wed, 19 Jun 2024 18:37:31 +0100
From: Conor Dooley <conor@...nel.org>
To: Detlev Casanova <detlev.casanova@...labora.com>
Cc: linux-kernel@...r.kernel.org,
	Ezequiel Garcia <ezequiel@...guardiasur.com.ar>,
	Mauro Carvalho Chehab <mchehab@...nel.org>,
	Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Heiko Stuebner <heiko@...ech.de>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Sebastian Reichel <sebastian.reichel@...labora.com>,
	Dragan Simic <dsimic@...jaro.org>,
	Diederik de Haas <didi.debian@...ow.org>,
	Andy Yan <andy.yan@...k-chips.com>,
	Boris Brezillon <boris.brezillon@...labora.com>,
	Hans Verkuil <hverkuil-cisco@...all.nl>,
	Daniel Almeida <daniel.almeida@...labora.com>,
	Paul Kocialkowski <paul.kocialkowski@...tlin.com>,
	Nicolas Dufresne <nicolas.dufresne@...labora.com>,
	Benjamin Gaignard <benjamin.gaignard@...labora.com>,
	Jonas Karlman <jonas@...boo.se>, Alex Bee <knaerzche@...il.com>,
	linux-media@...r.kernel.org, linux-rockchip@...ts.infradead.org,
	devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
	linux-staging@...ts.linux.dev
Subject: Re: [PATCH v2 3/4] media: dt-bindings: rockchip: Document RK3588
 Video Decoder bindings

On Wed, Jun 19, 2024 at 10:57:20AM -0400, Detlev Casanova wrote:
> Document the Rockchip RK3588 Video Decoder bindings.
> 
> Signed-off-by: Detlev Casanova <detlev.casanova@...labora.com>
> ---
>  .../bindings/media/rockchip,vdec.yaml         | 46 +++++++++++++++++++
>  1 file changed, 46 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/media/rockchip,vdec.yaml b/Documentation/devicetree/bindings/media/rockchip,vdec.yaml
> index 08b02ec16755..22cb62faaa9b 100644
> --- a/Documentation/devicetree/bindings/media/rockchip,vdec.yaml
> +++ b/Documentation/devicetree/bindings/media/rockchip,vdec.yaml
> @@ -17,6 +17,7 @@ properties:
>    compatible:
>      oneOf:
>        - const: rockchip,rk3399-vdec
> +      - const: rockchip,rk3588-vdec
>        - items:
>            - enum:
>                - rockchip,rk3228-vdec
> @@ -30,29 +31,56 @@ properties:
>      maxItems: 1
>  
>    clocks:
> +    minItems: 4
>      items:
>        - description: The Video Decoder AXI interface clock
>        - description: The Video Decoder AHB interface clock
>        - description: The Video Decoded CABAC clock
>        - description: The Video Decoder core clock
> +      - description: The Video decoder HEVC CABAC clock
>  
>    clock-names:
> +    minItems: 4
>      items:
>        - const: axi
>        - const: ahb
>        - const: cabac
>        - const: core
> +      - const: hevc_cabac
>  
>    assigned-clocks: true
>  
>    assigned-clock-rates: true
>  
> +  resets:
> +    items:
> +      - description: The Video Decoder AXI interface reset
> +      - description: The Video Decoder AHB interface reset
> +      - description: The Video Decoded CABAC reset
> +      - description: The Video Decoder core reset
> +      - description: The Video decoder HEVC CABAC reset
> +
> +  reset-names:
> +    items:
> +      - const: rst_axi
> +      - const: rst_ahb
> +      - const: rst_cabac
> +      - const: rst_core
> +      - const: rst_hevc_cabac
> +
>    power-domains:
>      maxItems: 1
>  
>    iommus:
>      maxItems: 1
>  
> +  sram:
> +    $ref: /schemas/types.yaml#/definitions/phandle
> +    description: |
> +      phandle to a reserved on-chip SRAM regions.
> +      Some SoCs, like rk3588 provide on-chip SRAM to store temporary
> +      buffers during decoding.
> +
>  required:
>    - compatible
>    - reg
> @@ -61,6 +89,24 @@ required:
>    - clock-names
>    - power-domains
>  
> +allOf:
> +  - if:
> +      properties:
> +        compatible:
> +          contains:
> +            const: rockchip,rk3588-vdec
> +    then:
> +      properties:
> +        clocks:
> +          minItems: 5
> +        clock-names:
> +          minItems: 5
> +
> +        resets:
> +          minItems: 5
> +        reset-names:
> +          minItems: 5

You need an else clause here to restrict sram, resets on the other
platforms and to cap clocks at maxItems: 4.

Thanks,
Conor.

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)