linux-kernel - Re: [PATCH] workqueue: Avoid nr_active manipulation in grabbing inactive items

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date: Wed, 19 Jun 2024 07:44:22 -1000
From: Tejun Heo <tj@...nel.org>
To: Lai Jiangshan <jiangshanlai@...il.com>
Cc: linux-kernel@...r.kernel.org,
	Lai Jiangshan <jiangshan.ljs@...group.com>
Subject: Re: [PATCH] workqueue: Avoid nr_active manipulation in grabbing
 inactive items

On Wed, Jun 19, 2024 at 06:39:34PM +0800, Lai Jiangshan wrote:
> From: Lai Jiangshan <jiangshan.ljs@...group.com>
> 
> Current try_to_grab_pending() activates the inactive item and
> subsequently treats it as though it were a standard activated item.
> 
> This approach prevents duplicating handling logic for both active and
> inactive items, yet the premature activation of an inactive item
> triggers trace_workqueue_activate_work(), yielding an unintended user
> space visible side effect.
> 
> And the unnecessary increment of the nr_active, which is not a simple
> counter now, followed by a counteracted decrement, is inefficient and
> complicates the code.
> 
> Just remove the nr_active manipulation code in grabbing inactive items.
> 
> Signed-off-by: Lai Jiangshan <jiangshan.ljs@...group.com>

Applied to wq/for-6.11.

Thanks.

-- 
tejun