linux-kernel - Re: [PATCH v5 2/2] dt-bindings: input: Goodix SPI HID Touchscreen

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date: Wed, 19 Jun 2024 19:09:05 +0100
From: Conor Dooley <conor@...nel.org>
To: Charles Wang <charles.goodix@...il.com>
Cc: dmitry.torokhov@...il.com, dan.carpenter@...aro.org, robh@...nel.org,
	dianders@...omium.org, krzk+dt@...nel.org, jikos@...nel.org,
	bentiss@...nel.org, hbarnor@...omium.org,
	linux-input@...r.kernel.org, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH v5 2/2] dt-bindings: input: Goodix SPI HID Touchscreen

On Wed, Jun 19, 2024 at 10:16:50AM +0800, Charles Wang wrote:
> Hi Conor,
> 
> On Tue, Jun 18, 2024 at 06:43:18PM +0100, Conor Dooley wrote:
> > On Tue, Jun 18, 2024 at 04:44:54PM +0800, Charles Wang wrote:

> > > +  reset-gpios:
> > > +    maxItems: 1
> > > +    description: reset gpio the chip is connected to.
> > 
> > The description here isn't needed, it's obvious :)
> >
> 
> Ack.
> 
> > > +  goodix,hid-report-addr:
> > > +    $ref: /schemas/types.yaml#/definitions/uint32
> > > +    description: |
> > 
> > This | is not needed, there's no formatting to preserve.
> > 
> > Those are nits:
> > Reviewed-by: Conor Dooley <conor.dooley@...rochip.com>
> > 
> 
> Thank you. If there is a next version, I will fix these.

Sounds good, thank you!

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)