linux-kernel - Re: [PATCH v2 3/5] kunit: string-stream-test: Make it a separate module

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <dd58758a-7689-48a3-bc89-2cef3858c4b4@quicinc.com>
Date: Wed, 19 Jun 2024 11:09:14 -0700
From: Jeff Johnson <quic_jjohnson@...cinc.com>
To: Ivan Orlov <ivan.orlov0322@...il.com>, <brendan.higgins@...ux.dev>,
        <davidgow@...gle.com>, <rmoar@...gle.com>
CC: <linux-kselftest@...r.kernel.org>, <kunit-dev@...glegroups.com>,
        <linux-kernel@...r.kernel.org>, <skhan@...uxfoundation.org>
Subject: Re: [PATCH v2 3/5] kunit: string-stream-test: Make it a separate
 module

On 6/18/24 10:03, Ivan Orlov wrote:
> Currently, the only way to build string-stream-test is by setting
> CONFIG_KUNIT_TEST=y. However, CONFIG_KUNIT_TEST is a config option for
> a different test (`kunit-test.c`).
> 
> Introduce a new Kconfig entry in order to be able to build the
> string-stream-test test as a separate module. Import the KUnit namespace
> in the test so we could have string-stream functions accessible.
> 
> Reviewed-by: David Gow <davidgow@...gle.com>
> Signed-off-by: Ivan Orlov <ivan.orlov0322@...il.com>
> ---
> V1 -> V2:
> - No changes
> 
>   lib/kunit/Kconfig              | 8 ++++++++
>   lib/kunit/Makefile             | 2 +-
>   lib/kunit/string-stream-test.c | 2 ++
>   3 files changed, 11 insertions(+), 1 deletion(-)
> 
...

> diff --git a/lib/kunit/string-stream-test.c b/lib/kunit/string-stream-test.c
> index 7511442ea98f..d03cac934e04 100644
> --- a/lib/kunit/string-stream-test.c
> +++ b/lib/kunit/string-stream-test.c
> @@ -534,3 +534,5 @@ static struct kunit_suite string_stream_test_suite = {
>   	.init = string_stream_test_init,
>   };
>   kunit_test_suites(&string_stream_test_suite);
> +MODULE_IMPORT_NS(EXPORTED_FOR_KUNIT_TESTING);
> +MODULE_LICENSE("GPL");

missing MODULE_DESCRIPTION()
this will cause a warning with make W=1