[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <a9465b9a-1bfd-4ec1-b641-21867584c9d9@lunn.ch>
Date: Wed, 19 Jun 2024 21:19:38 +0200
From: Andrew Lunn <andrew@...n.ch>
To: Bartosz Golaszewski <brgl@...ev.pl>
Cc: Vinod Koul <vkoul@...nel.org>,
Alexandre Torgue <alexandre.torgue@...s.st.com>,
Jose Abreu <joabreu@...opsys.com>,
"David S . Miller" <davem@...emloft.net>,
Eric Dumazet <edumazet@...gle.com>,
Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>,
Maxime Coquelin <mcoquelin.stm32@...il.com>,
Heiner Kallweit <hkallweit1@...il.com>,
Russell King <linux@...linux.org.uk>, netdev@...r.kernel.org,
linux-arm-msm@...r.kernel.org,
linux-stm32@...md-mailman.stormreply.com,
linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
Bartosz Golaszewski <bartosz.golaszewski@...aro.org>
Subject: Re: [PATCH net-next 4/8] net: phy: aquantia: add support for aqr115c
> case MDIO_PHYXS_VEND_IF_STATUS_TYPE_OCSGMII:
> - phydev->interface = PHY_INTERFACE_MODE_2500BASEX;
> + phydev->interface = PHY_INTERFACE_MODE_OCSGMII;
That looks interesting. I wounder what will break.
> break;
> default:
> phydev->interface = PHY_INTERFACE_MODE_NA;
> @@ -721,6 +721,18 @@ static int aqr113c_config_init(struct phy_device *phydev)
> return aqr107_fill_interface_modes(phydev);
> }
>
> +static int aqr115c_config_init(struct phy_device *phydev)
> +{
> + /* Check that the PHY interface type is compatible */
> + if (phydev->interface != PHY_INTERFACE_MODE_SGMII &&
> + phydev->interface != PHY_INTERFACE_MODE_OCSGMII)
> + return -ENODEV;
Does it support 2500BaseX?
Andrew
Powered by blists - more mailing lists