linux-kernel - Re: [PATCH] filemap: add trace events for get_pages, map

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ZnNHvwV7tDlSFx8Y@casper.infradead.org>
Date: Wed, 19 Jun 2024 22:03:59 +0100
From: Matthew Wilcox <willy@...radead.org>
To: Takaya Saeki <takayas@...omium.org>
Cc: Andrew Morton <akpm@...ux-foundation.org>,
	Steven Rostedt <rostedt@...dmis.org>,
	Masami Hiramatsu <mhiramat@...nel.org>,
	Mathieu Desnoyers <mathieu.desnoyers@...icios.com>,
	Junichi Uekawa <uekawa@...omium.org>, linux-kernel@...r.kernel.org,
	linux-trace-kernel@...r.kernel.org, linux-fsdevel@...r.kernel.org,
	linux-mm@...ck.org
Subject: Re: [PATCH] filemap: add trace events for get_pages, map_pages, and
 fault

On Tue, Jun 18, 2024 at 09:36:56AM +0000, Takaya Saeki wrote:
> +	TP_printk(
> +		"dev %d:%d ino %lx ofs=%lu max_ofs=%lu",

It seems weird to have a space between dev and %d, but an equals between
ofs and %lu.  I see there is some precedent for this elsewhere, but
there are other places which use ino=.  I'd rather:

		"dev=%d:%d ino=%lx ofs=%lu max_ofs=%lu",

> +	TP_printk(
> +		"dev %d:%d ino %lx ofs=%lu",

Likewise.

> +		MAJOR(__entry->s_dev),
> +		MINOR(__entry->s_dev), __entry->i_ino,
> +		__entry->index << PAGE_SHIFT

This needs to be cast to an loff_t before shifting.