linux-kernel - Re: [PATCH] English fixes in vmalloced kernel stacks documentation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87iky44ouc.fsf@trenco.lwn.net>
Date: Wed, 19 Jun 2024 15:14:35 -0600
From: Jonathan Corbet <corbet@....net>
To: Nir Lichtman <nir@...htman.org>, linux-doc@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] English fixes in vmalloced kernel stacks documentation

Thanks for working to improve our documentation!

That said...

Nir Lichtman <nir@...htman.org> writes:

> From cdc9d82bad7111ab1f132d1264fa6ffa323c26b0 Mon Sep 17 00:00:00 2001
> From: Nir Lichtman <nir@...htman.org>
> Date: Wed, 19 Jun 2024 23:57:11 +0300
> Subject: [PATCH] English fixes in vmalloced kernel stacks documentation

All patches need a proper changelog, and this is not it.  Please have a
look at Documentation/process/submitting-patches.rst for information on
how to describe your change.

Please pay attention to the section on Signed-off-by while you are there
as well.

> ---
>  Documentation/mm/vmalloced-kernel-stacks.rst | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/Documentation/mm/vmalloced-kernel-stacks.rst b/Documentation/mm/vmalloced-kernel-stacks.rst
> index fc8c67833..b4ca3176e 100644
> --- a/Documentation/mm/vmalloced-kernel-stacks.rst
> +++ b/Documentation/mm/vmalloced-kernel-stacks.rst
> @@ -20,9 +20,9 @@ Introduction
>  
>  Kernel stack overflows are often hard to debug and make the kernel
>  susceptible to exploits. Problems could show up at a later time making
> -it difficult to isolate and root-cause.
> +it difficult to pinpoint their root cause.

This is a change in meaning and is not necessarily an improvement.

The other changes are fine.

Thanks,

jon